Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set correct height for tabs #854

Merged
merged 3 commits into from
Dec 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

# Next

- [Fix] Add top and bottom paddings to the `Tab` component.

# 26.2.4

- [Fix] The `Prose` component's horizontal rule color is now properly set to the primary divider color.
Expand Down
5 changes: 3 additions & 2 deletions src/tabs/tabs.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@
--reactist-tab-track-border-width: 2px;
--reactist-tab-border-radius: 20px;
--reactist-tab-border-width: 1px;
--reactist-tab-height: 30px;
--reactist-tab-padding-x: var(--reactist-spacing-medium);
--reactist-tab-padding-y: var(--reactist-spacing-small);
--reactist-tab-line-height: 21px;
}

.tab {
box-sizing: border-box;
padding: 0 var(--reactist-spacing-medium);
padding: var(--reactist-tab-padding-y) var(--reactist-tab-padding-x);
border: none;
background: none;
cursor: pointer;
Expand Down
4 changes: 3 additions & 1 deletion src/tabs/tabs.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@ Their size can also be customized with:
--reactist-tab-track-border-width
--reactist-tab-border-radius
--reactist-tab-border-width
--reactist-tab-height
--reactist-tab-padding-x
--reactist-tab-padding-y
--reactist-tab-line-height
```

## Stories
Expand Down
Loading