-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-5816 locale splash screen #14118
Merged
QilongTang
merged 62 commits into
DynamoDS:master
from
jesusalvino:DYN-5816-locale-splash-screen
Aug 9, 2023
Merged
Changes from 12 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
18c74c4
Display the proper language in the Splash Screen
jesusalvino 2ebe836
spacing RootDirectories
jesusalvino 9614f08
Keeping spacing
jesusalvino b265118
Remove Splash Screen default title
jesusalvino 4766900
Dissect the Preferences creation from the DynamoModel ctor
jesusalvino 7194409
removing null validation
jesusalvino fe25ed1
Refactoring based on the PathManager and Preferences
f27f2de
Adding a PathManager and Preference singleton
49cfc60
cleaning text
4da1ea6
PathManager and PreferenceSetttings as singleton
695628c
Cleaning spacing and others
1fb48cb
Using the singleton PathManager class instead of the Interface
db89a94
Changing the scope and documenting the function CreateIPathResolver
fb647ec
Changing access to be flexible for integrators
777f584
Removing unused function
4c42d65
Setting the Preferences to the RecorderTests
7dd7321
Add the PreferenceSettings.Instance to the DynamoCoreTests setup
06bbbd4
Adding the preference settings to the DynamoTestUIBase Start configur…
1aefe4a
Set the Preferences to the SystemTesttBase
2ce8be4
Set the PreferenceSettings.Instance to the DynamoViewModelUnitTest Start
d229f81
Dealing with the PathResolver
0b3902f
Passing the Preferences to the DynamoModel Start function and update …
1f449e0
Passing the Prererences to the VisualizationTest Start
b63a8dd
Update the MakeCLIModel function
2eab90c
Passing the Preferences to the DefaultStartConfiguration
9e1f6d9
merge master-resolve conflicts
reddyashish b50b5e4
Update AssemblySharedInfo.cs
reddyashish ff3862c
Passing the settings to the configuration from the parameter
6fc2258
untouch the hostApplicationDirectory
e81b146
Untouching the preLoadedLibraries field and renaming
9da3a1f
Restoring fields and adding doc
f4bafcd
Adding the preferences to the start of some tests
7ed64f7
Validating the settings in the DynamoModelTestBase setup
4dfdef4
Adding Preferences to the config Settings Test
7252051
Refactoring the PathManager and Preference creation on the DynamoMode…
1ddba71
Merge branch 'master' into DYN-5816-locale-splash-screen
84e111d
Cleaning Tests setup and ignore Pref Instance property for xml
37620ba
Merge branch 'DynamoDS:master' into DYN-5816-locale-splash-screen
jesusalvino 1321eb7
Merge branch 'DynamoDS:master' into DYN-5816-locale-splash-screen
jesusalvino 8c3ee26
Removing Pref Singleton to the CoreTest Setup
cc58ece
Rollback fron the 6213 commit
90e4a7f
Merge branch 'master' into DYN-5816-locale-splash-screen
1f0d671
keep the StartInTestMode to false since this is an special case and s…
e14ee63
Handling Preferences
fe980b9
clieaning references
4771ed4
Saving them with the proper Unicode
33a5d63
Removing Singletion Preferences
e5e92ab
Explicit Settings since the StartInTestMode is false
745a431
Add the specific Preferences
53d2218
Rollback the cc58
2539d97
Rollback the cc58
b630a38
Merge branch 'master' of https://github.com/jesusalvino/Dynamo
06ea6c5
Merge branch 'master' into DYN-5816-T1
2caf714
Fix Solution
c290e73
Fixing the Assembly character and test file
63e905a
Merge branch 'master' into DYN-5816-locale-splash-screen
87636bb
Merge branch 'DYN-5816-T1' into DYN-5816-locale-splash-screen
d10541a
Forcing to update the cc58 commit
549e3c2
Removing the test file
162fe2c
Fixing Tests Unicode
d2f3731
No new line
5a22b9d
Merge branch 'DynamoDS:master' into DYN-5816-locale-splash-screen
jesusalvino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested in DynamoRevit yet? These string.empty params later will cause certain folder property to be missing. For sandbox it is OK but for integration case, we get these from the integration code. Unless you meant to not reuse the same pathResolver later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QilongTang Works fine in Revit. Jesus has tested it.
@jesusalvino Can you expand why we are just initializing pathResolver with the empty arguments here? I see that you are setting the pathResolver correctly in DynamoModel constructor(Line 674)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this function not called by integrators, if not, then probably OK this way