DYN-5816 locale splash screen #14118

jesusalvino · 2023-06-29T14:21:21Z

Purpose

Display the proper language in the beginning of the Splash Screen according to the user preference | improvement https://jira.autodesk.com/browse/DYN-5816

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Reviewers

@QilongTang
@reddyashish

FYIs

@RobertGlobant20
@Enzo707

jesusalvino · 2023-06-29T14:21:54Z

src/DynamoApplications/StartupUtils.cs

src/DynamoCore/Configuration/PathManager.cs

src/DynamoCore/Models/DynamoModel.cs

src/DynamoApplications/StartupUtils.cs

src/DynamoApplications/PathManagerPreference.cs

QilongTang · 2023-07-14T19:45:31Z

src/DynamoApplications/StartupUtils.cs

@@ -273,6 +275,13 @@ public static DynamoModel MakeModel(bool CLImode, string asmPath = "", string ho
        /// <returns></returns>
        public static DynamoModel MakeModel(bool CLImode, string asmPath = "", HostAnalyticsInfo info = new HostAnalyticsInfo())
        {
+            IPathResolver pathResolver = CreateIPathResolver(false, string.Empty, string.Empty, string.Empty);            


Have you tested in DynamoRevit yet? These string.empty params later will cause certain folder property to be missing. For sandbox it is OK but for integration case, we get these from the integration code. Unless you meant to not reuse the same pathResolver later?

src/DynamoApplications/StartupUtils.cs

src/DynamoCore/Configuration/PathManager.cs

src/DynamoCore/Models/DynamoModel.cs

src/DynamoCore/Configuration/PathManager.cs

src/DynamoCore/Configuration/PreferenceSettings.cs

mjkkirschner · 2023-07-15T01:10:13Z

@QilongTang @jesusalvino I have not looked too deeply at this PR - but consider:

that making things static is a good way to have interesting memory leaks during testing ... it all depends of course.
that the tests need to mock these objects to control Dynamo and if they are all modifying the same static instance you may find strange testing behavior.
when you use static objects you may need to think harder about concurrency ... again it depends if the usage is obviously or not the same object.... global objects in general make multi threading harder - not that I know this applies here specifically.

QilongTang · 2023-07-19T19:21:32Z

Looks like none of the smoke tests passed, so we need further work here..

QilongTang · 2023-08-08T16:23:24Z

@jesusalvino What is the state of this PR? Any remaining known regressions?

jesusalvino · 2023-08-08T16:27:36Z

@jesusalvino What is the state of this PR? Any remaining known regressions?

No regression issues, I have just cleaned a file and some unicodes issues, all clean with this PR, I think is ready.

QilongTang · 2023-08-08T16:31:26Z

Thank you @jesusalvino Will wait for the PR checks

QilongTang · 2023-08-08T20:39:48Z

@jesusalvino There are 20 reported regressions, please check

jesusalvino · 2023-08-08T20:51:36Z

@jesusalvino There are 20 reported regressions, please check

They look new, I will check them for sure.

jesusalvino · 2023-08-08T22:23:53Z

@jesusalvino There are 20 reported regressions, please check

@QilongTang I have validated them and they don't work even locally in a fresh master branch. After asking to the Team I have realized they are related to https://autodesk.slack.com/archives/C1866AFQB/p1691517645345439

* Display the proper language in the Splash Screen * spacing RootDirectories * Keeping spacing * Remove Splash Screen default title * Dissect the Preferences creation from the DynamoModel ctor * removing null validation * Refactoring based on the PathManager and Preferences * Adding a PathManager and Preference singleton * cleaning text * PathManager and PreferenceSetttings as singleton * Cleaning spacing and others * Using the singleton PathManager class instead of the Interface * Changing the scope and documenting the function CreateIPathResolver * Changing access to be flexible for integrators * Removing unused function * Setting the Preferences to the RecorderTests * Add the PreferenceSettings.Instance to the DynamoCoreTests setup * Adding the preference settings to the DynamoTestUIBase Start configuration * Set the Preferences to the SystemTesttBase * Set the PreferenceSettings.Instance to the DynamoViewModelUnitTest Start * Dealing with the PathResolver * Passing the Preferences to the DynamoModel Start function and update a comment * Passing the Prererences to the VisualizationTest Start * Update the MakeCLIModel function * Passing the Preferences to the DefaultStartConfiguration * Update AssemblySharedInfo.cs * Passing the settings to the configuration from the parameter * untouch the hostApplicationDirectory * Untouching the preLoadedLibraries field and renaming * Restoring fields and adding doc * Adding the preferences to the start of some tests * Validating the settings in the DynamoModelTestBase setup * Adding Preferences to the config Settings Test * Refactoring the PathManager and Preference creation on the DynamoModel ctor and DynamoModelTestBase * Cleaning Tests setup and ignore Pref Instance property for xml * Removing Pref Singleton to the CoreTest Setup * Rollback fron the 6213 commit * keep the StartInTestMode to false since this is an special case and set an explicit preferences instance * Handling Preferences * clieaning references * Saving them with the proper Unicode * Removing Singletion Preferences * Explicit Settings since the StartInTestMode is false * Add the specific Preferences * Rollback the cc58 * Rollback the cc58 * Fix Solution * Fixing the Assembly character and test file * Forcing to update the cc58 commit * Removing the test file * Fixing Tests Unicode * No new line --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> Co-authored-by: reddyashish <[email protected]>

pinzart90 · 2023-08-14T15:33:07Z

src/DynamoCore/Configuration/PathManager.cs

@@ -48,8 +48,15 @@ struct PathManagerParams
        internal IPathResolver PathResolver { get; set; }
    }

-    class PathManager : IPathManager
+    public class PathManager : IPathManager


I want to clarify that all of the public methods of this class (which were hidden before because the class was private) are now going to be exposed as public members of the class. Not sure if this was intended
FYI @mjkkirschner @QilongTang

This is a good point. @jesusalvino Does PathManager need to be a public singleton or internal?

@QilongTang I think keep it within the .Core namespace should be enough, I will take a look

prefer internal if possible!

Guys this is the PR #14263

jesusalvino added 3 commits June 29, 2023 09:08

Display the proper language in the Splash Screen

18c74c4

spacing RootDirectories

2ebe836

Keeping spacing

9614f08

avidit changed the title ~~Dyn 5816 locale splash screen~~ DYN-5816 locale splash screen Jun 29, 2023

Remove Splash Screen default title

b265118

QilongTang added this to the 2.19.0 milestone Jun 30, 2023

QilongTang reviewed Jun 30, 2023

View reviewed changes

src/DynamoApplications/StartupUtils.cs Outdated Show resolved Hide resolved

jesusalvino added 2 commits June 30, 2023 16:06

Dissect the Preferences creation from the DynamoModel ctor

4766900

removing null validation

7194409

QilongTang reviewed Jul 6, 2023

View reviewed changes

src/DynamoCore/Configuration/PathManager.cs Outdated Show resolved Hide resolved

reddyashish reviewed Jul 6, 2023

View reviewed changes

src/DynamoCore/Models/DynamoModel.cs Outdated Show resolved Hide resolved

Refactoring based on the PathManager and Preferences

fe25ed1

QilongTang reviewed Jul 12, 2023

View reviewed changes

src/DynamoApplications/StartupUtils.cs Outdated Show resolved Hide resolved

Jesus Alfredo Alviño added 2 commits July 12, 2023 12:17

Adding a PathManager and Preference singleton

f27f2de

cleaning text

49cfc60

QilongTang reviewed Jul 12, 2023

View reviewed changes

src/DynamoApplications/PathManagerPreference.cs Outdated Show resolved Hide resolved

Jesus Alfredo Alviño added 2 commits July 13, 2023 16:34

PathManager and PreferenceSetttings as singleton

4da1ea6

Cleaning spacing and others

695628c

QilongTang reviewed Jul 14, 2023

View reviewed changes

src/DynamoApplications/StartupUtils.cs Outdated Show resolved Hide resolved

QilongTang reviewed Jul 14, 2023

View reviewed changes

src/DynamoCore/Configuration/PathManager.cs Outdated Show resolved Hide resolved

QilongTang reviewed Jul 14, 2023

View reviewed changes

src/DynamoCore/Models/DynamoModel.cs Outdated Show resolved Hide resolved

Using the singleton PathManager class instead of the Interface

1fb48cb

QilongTang reviewed Jul 14, 2023

View reviewed changes

src/DynamoCore/Models/DynamoModel.cs Outdated Show resolved Hide resolved

mjkkirschner reviewed Jul 15, 2023

View reviewed changes

src/DynamoCore/Configuration/PathManager.cs Show resolved Hide resolved

mjkkirschner reviewed Jul 15, 2023

View reviewed changes

src/DynamoCore/Configuration/PreferenceSettings.cs Show resolved Hide resolved

Changing the scope and documenting the function CreateIPathResolver

db89a94

Jesus Alfredo Alviño added 18 commits August 4, 2023 19:41

Handling Preferences

e14ee63

clieaning references

fe980b9

Saving them with the proper Unicode

4771ed4

Removing Singletion Preferences

33a5d63

Explicit Settings since the StartInTestMode is false

e5e92ab

Add the specific Preferences

745a431

Rollback the cc58

53d2218

Rollback the cc58

2539d97

Merge branch 'master' of https://github.com/jesusalvino/Dynamo

b630a38

Merge branch 'master' into DYN-5816-T1

06ea6c5

Fix Solution

2caf714

Fixing the Assembly character and test file

c290e73

Merge branch 'master' into DYN-5816-locale-splash-screen

63e905a

Merge branch 'DYN-5816-T1' into DYN-5816-locale-splash-screen

87636bb

Forcing to update the cc58 commit

d10541a

Removing the test file

549e3c2

Fixing Tests Unicode

162fe2c

No new line

d2f3731

Merge branch 'DynamoDS:master' into DYN-5816-locale-splash-screen

5a22b9d

QilongTang merged commit 542dcfb into DynamoDS:master Aug 9, 2023
18 checks passed

QilongTang mentioned this pull request Aug 9, 2023

DYN-5816 locale splash screen (#14118) #14246

Merged

9 tasks

QilongTang mentioned this pull request Aug 10, 2023

Pass the Preferences as part of the Initializacion configuration DynamoDS/DynamoRevit#2933

Merged

5 tasks

pinzart90 reviewed Aug 14, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DYN-5816 locale splash screen #14118

DYN-5816 locale splash screen #14118

jesusalvino commented Jun 29, 2023

jesusalvino commented Jun 29, 2023

QilongTang Jul 14, 2023 •

edited

Loading

mjkkirschner commented Jul 15, 2023 •

edited

Loading

QilongTang commented Jul 19, 2023

QilongTang commented Aug 8, 2023

jesusalvino commented Aug 8, 2023

QilongTang commented Aug 8, 2023

QilongTang commented Aug 8, 2023

jesusalvino commented Aug 8, 2023

jesusalvino commented Aug 8, 2023

pinzart90 Aug 14, 2023

QilongTang Aug 14, 2023 •

edited

Loading

jesusalvino Aug 14, 2023 •

edited

Loading

mjkkirschner Aug 14, 2023

jesusalvino Aug 15, 2023

DYN-5816 locale splash screen #14118

DYN-5816 locale splash screen #14118

Conversation

jesusalvino commented Jun 29, 2023

Purpose

Declarations

Reviewers

FYIs

jesusalvino commented Jun 29, 2023

QilongTang Jul 14, 2023 • edited Loading

Choose a reason for hiding this comment

mjkkirschner commented Jul 15, 2023 • edited Loading

QilongTang commented Jul 19, 2023

QilongTang commented Aug 8, 2023

jesusalvino commented Aug 8, 2023

QilongTang commented Aug 8, 2023

QilongTang commented Aug 8, 2023

jesusalvino commented Aug 8, 2023

jesusalvino commented Aug 8, 2023

pinzart90 Aug 14, 2023

Choose a reason for hiding this comment

QilongTang Aug 14, 2023 • edited Loading

Choose a reason for hiding this comment

jesusalvino Aug 14, 2023 • edited Loading

Choose a reason for hiding this comment

mjkkirschner Aug 14, 2023

Choose a reason for hiding this comment

jesusalvino Aug 15, 2023

Choose a reason for hiding this comment

QilongTang Jul 14, 2023 •

edited

Loading

mjkkirschner commented Jul 15, 2023 •

edited

Loading

QilongTang Aug 14, 2023 •

edited

Loading

jesusalvino Aug 14, 2023 •

edited

Loading