-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helix upgrade #14134
helix upgrade #14134
Conversation
I see this failure on the 4.8 build: E:\Builds\Dynamo_master\Dynamo\src\DynamoCoreWpf\DynamoCoreWpf.csproj(1722,3): error MSB4025: The project file could not be loaded. The 'ItemGroup' start tag on line 134 position 4 does not match the end tag of 'Project'. Line 1722, position 3 |
@sm6srw I can't replicate that, actually DynamoCoreWpf.csproj doesn't have a 1722 line. Can you please give me more details? |
@marbelarrietaGlobant I have only seen it on one of the build machines. Can you resolve the conflicts and push again? Thanks! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
if (Environment.Is64BitProcess) | ||
NativeMethods.LoadNvApi64(); | ||
else | ||
NativeMethods.LoadNvApi32(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we have 32 bit support here just because this code has been copy pasted right >?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I also asked about this class being removed here:
helix-toolkit/helix-toolkit#2004 ... so - not sure it will work.
you can give this blog post on a related tool a read if you are interested -
https://www.toptensoftware.com/blog/nvpatch-how-it-works/
though it seems we might be able to do something now that .net supports native external callers ...
anyway, that blog post and this method don't seem to work the same way so there must be more to it than an exported member in the pe file. I guess?
For the time being, I think this is safe enough even if it does not work - we'll just have to pay attention to reports of users needing to explicitly set hardware accel again for sandbox - like back in the dark ages 😉 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question about NVidia native binary import then LGTM
Purpose
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of