Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helix upgrade #14134
helix upgrade #14134
Changes from all commits
a00ddde
fa59635
b7f9385
dc65a77
a423b8c
918e91c
c6c776e
ce7962d
7152ff0
76a5d35
d2d2549
7acaf82
d518661
0b731d4
0f7fb1d
80a80d2
a3ae207
d3a890c
f4bc5ca
0a5aac1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we have 32 bit support here just because this code has been copy pasted right >?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I also asked about this class being removed here:
helix-toolkit/helix-toolkit#2004 ... so - not sure it will work.
you can give this blog post on a related tool a read if you are interested -
https://www.toptensoftware.com/blog/nvpatch-how-it-works/
though it seems we might be able to do something now that .net supports native external callers ...
anyway, that blog post and this method don't seem to work the same way so there must be more to it than an exported member in the pe file. I guess?
For the time being, I think this is safe enough even if it does not work - we'll just have to pay attention to reports of users needing to explicitly set hardware accel again for sandbox - like back in the dark ages 😉 )