remove IronPython code and extension #14706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,6 @@ public class IronPythonCompletionData : ICompletionData | |||
| { | |||
There was a problem hiding this comment.
Is this class also used for autocomplete in PythonNet?
There was a problem hiding this comment.
no, it's used to decouple AvalonEdit's interface (and WPF deps) from the core completion types. We can think of this as a UI type, thats why it's in this PythonWPF assembly.
There was a problem hiding this comment.
we could move potentially move it to the new repo... but we'd need to introduce a new assembly there and then that package would depend on UI types.
I was thinking the trade off of leaving it here for UI was worth it so that the DSIronPython package was nicely cross platform.
aparajit-pratap
approved these changes
Dec 7, 2023
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Dec 10, 2023
* remove legacy completion provider * remove * remove obsolete -arguable tests seem to pass going to merge this and cherry pick to 3.0
mjkkirschner
added a commit
that referenced
this pull request
Dec 11, 2023
mjkkirschner
added a commit
that referenced
this pull request
Dec 15, 2023
* remove IronPython code and extension (#14706) * remove legacy completion provider * remove * remove obsolete -arguable tests seem to pass going to merge this and cherry pick to 3.0 * update py pack target and dont migrate * modify so we can add test for migrator * update test mock data.
mjkkirschner
added a commit
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes DSIronPython, IronPythonExtension, IronPythonTests and as much of the old completion provider code as possible as they are replaced by:
https://github.com/DynamoDS/DSIronPython
It also remove obsolete events.
Declarations
Check these if you believe they are true
*.resxfiles