-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove IronPython code and extension #14706
Conversation
@@ -15,7 +15,6 @@ public class IronPythonCompletionData : ICompletionData | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this class also used for autocomplete in PythonNet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's used to decouple AvalonEdit's interface (and WPF deps) from the core completion types. We can think of this as a UI type, thats why it's in this PythonWPF assembly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could move potentially move it to the new repo... but we'd need to introduce a new assembly there and then that package would depend on UI types.
I was thinking the trade off of leaving it here for UI was worth it so that the DSIronPython package was nicely cross platform.
* remove legacy completion provider * remove * remove obsolete -arguable tests seem to pass going to merge this and cherry pick to 3.0
* remove IronPython code and extension (#14706) * remove legacy completion provider * remove * remove obsolete -arguable tests seem to pass going to merge this and cherry pick to 3.0 * update py pack target and dont migrate * modify so we can add test for migrator * update test mock data.
Purpose
This PR removes DSIronPython, IronPythonExtension, IronPythonTests and as much of the old completion provider code as possible as they are replaced by:
https://github.com/DynamoDS/DSIronPython
It also remove obsolete events.
Declarations
Check these if you believe they are true
*.resx
files