DYN-6440 Custom Selection Overlapped #14960
Conversation
When choosing a large string text from the ComboBox was overlapping other controls at left side so for fixing this bug I've set the MaxWidth property and also I've added a tooltip showing the text (this will be useful when we have a large string).
Adding a new TextBlock that when has a large text will wrap the text show at the end the chars: "..."
Fixing TextBlock Style
|
This is a GIF showing the expected behavior for Custom Selection node. |
src/Libraries/CoreNodeModelsWpf/NodeViewCustomizations/CustomSelection.cs
Show resolved
Hide resolved
Adding property in the Model so we can control the TextBlock Visibility.
Removed unused using
UI Smoke TestsTest: success. 2 passed, 0 failed. |
src/Libraries/CoreNodeModelsWpf/NodeViewCustomizations/CustomSelection.cs
Show resolved
Hide resolved
|
|
||
| formControl.BaseComboBox = dropdown; | ||
| formControl.BaseComboBox.SelectionChanged += BaseComboBox_SelectionChanged; |
There was a problem hiding this comment.
For unsubscribing the method I added the Dispose() method but not sure if this class is being disposed correctly or not.
It's supposed that if you derive from IDispose and implement the Dispose() method the right way to dispose the object should be by using the "using(instance)" or by calling object.Dispose() directly.
commit: c08ab0e
There was a problem hiding this comment.
Thanks would you test when workspace is closed, if the dispose function is called? Just curious about the conclusion
There was a problem hiding this comment.
@QilongTang you were right, when closing the workspace the Dispose method is being reached.
Added more comments for clarifying the use of the IsVisibleDropDownTextBlock property. Also I've added the Dispose() method for unsubscribing event handlers (although I'm not so sure if we are disposing this class correctly).
Purpose
Fixing problem with large text in the Custom Selection nodes.
When choosing a large string text from the ComboBox was overlapping other controls at left side then for fixing this bug I've added a new TextBlock that will hidden for all the nodes but will be shown just for Custom Selection nodes.
This new TextBlock will show "..." at the end of the string when trying to display a very large text.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing problem with large text in the Custom Selection nodes.
Reviewers
@QilongTang
FYIs
@avidit