Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6440 Custom Selection Overlapped #14960

Merged
merged 6 commits into from
Feb 26, 2024
Merged

DYN-6440 Custom Selection Overlapped #14960

merged 6 commits into from
Feb 26, 2024

Commits on Feb 20, 2024

  1. DYN-6440 Custom Selection node overlapping

    When choosing a large string text from the ComboBox was overlapping other controls at left side so for fixing this bug I've set the MaxWidth property and also I've added a tooltip showing the text (this will be useful when we have a large string).
    RobertGlobant20 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8c8e9e0 View commit details
    Browse the repository at this point in the history
  2. DYN-6440 Custom Selection node overlapping

    Adding a new TextBlock that when has a large text will wrap the text show at the end the chars: "..."
    RobertGlobant20 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    cd055bf View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. DYN-6440 Custom Selection node overlapping

    Fixing TextBlock Style
    RobertGlobant20 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    95bef1e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. DYN-6440 Custom Selection node overlapping Code Review

    Adding property in the Model so we can control the TextBlock Visibility.
    RobertGlobant20 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9721ab0 View commit details
    Browse the repository at this point in the history
  2. DYN-6440 Custom Selection node overlapping Code Review

    Removed unused using
    RobertGlobant20 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3b3b57c View commit details
    Browse the repository at this point in the history
  3. DYN-6440 Custom Selection node overlapping Code Review

    Added more comments for clarifying the use of the IsVisibleDropDownTextBlock  property.
    Also I've added the Dispose() method for unsubscribing event handlers (although I'm not so sure if we are disposing this class correctly).
    RobertGlobant20 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c08ab0e View commit details
    Browse the repository at this point in the history