-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6607 - Input/Output Node - part 1 FIX #15037
Conversation
- fixes a number of tests causing - some tests are already fixed due to upcoming changes in a follow-up PR - these were temporarily ignored
I cant find the pull request validation job for this PR.. So I started https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1415/ for you |
One regression from the job: Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings |
- fixed TestImportCopySettings by adding the new Preference property to the test settings file
Thank you, @QilongTang ! I don't know how this went in - it was a new property added to the Preferences - |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
@@ -40,6 +40,7 @@ | |||
<BackupFiles> | |||
<string>C:\Users\user\Documents\dynamofile.dyn</string> | |||
</BackupFiles> | |||
<TemplateFilePath>C:\ProgramData\Dynamo\Dynamo Core\templates\en-US</TemplateFilePath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeusongit It looks like now this property is serialized always? Although the value could be empty. Please confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @QilongTang - I am not the author of the preference property, I assume it's a new addition.
TemplateFilePath = string.Empty; |
The test picks it up as the number of default preferences coming from
PreferenceSettings.cs
was different then the one specified in the test file. I just added the entry in the test file to account for the new property and fix the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this answers the question, but I am not sure if the property should or shouldn't be serialized.
This reverts commit 97e2d46. # Conflicts: # test/Tools/NodeDocumentationMarkdownGeneratorTests/MarkdownGeneratorCommandTests.cs
Purpose
Fixes a number of failing tests blocking master-15.
Ignored tests are already fixed in the follow-up PR #15022 (probably a mix-up when cherry-picking).
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@QilongTang
@mjkkirschner
FYIs
@saintentropy
@twastvedt