Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6775 Updating SplashScreen Version #15085

Merged
merged 1 commit into from
Apr 4, 2024
Merged

DYN-6775 Updating SplashScreen Version #15085

merged 1 commit into from
Apr 4, 2024

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

DYN-6775 Updating SplashScreen Version

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

DYN-6775 Updating SplashScreen Version

Reviewers

@QilongTang

FYIs

DYN-6775 Updating SplashScreen Version
@QilongTang
Copy link
Contributor

QilongTang commented Apr 3, 2024

hi @RobertGlobant20 It's not published yet right? https://www.npmjs.com/package/@dynamods/splash-screen. Please bump up the version in the other repo and publish a release to make it happen

@QilongTang QilongTang added this to the 3.1 milestone Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang
Copy link
Contributor

QilongTang commented Apr 4, 2024

I rerun the checks and not sure Bin Diff job keeps failing but I think it should not be relevant to this PR. In the future I would suggest making sure the npm js package is published before making the PR, otherwise lots of the checks will fail anyway

@QilongTang QilongTang merged commit 1c49b2d into DynamoDS:master Apr 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants