Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6857-homepage-preferences #15139

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 16, 2024

Purpose

This PR addresses a jira request for improvement of the HomePage: As a Dynamo user, I want Grid/List view option picked on Dynamo Home persist across sessions https://jira.autodesk.com/browse/DYN-6857.

As a Dynamo user, I want Grid/List view option picked on Dynamo Home persist across sessions.

  • Needs to be serialized
  • Needs to persist across session
  • Do not require user to set initial value
  • Preferred to be migrated with newer version of Dynamo launch

We have examples in Preferences Settings just like this, e.g. Dynamo Window Default size, Dynamo Library Default size, etc. Although this setting is not expected to be exposed in settings panel

Works with the following HomePage changes: DynamoDS/DynamoHome#13

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • added a single serialized property that unpacks into a dictionary of items which are sent to the front-end HomePage each time Dynamo is started
  • the single property would allow any number of settings to be stored in the future without the need to alter the back-end side
  • currently 2 properties are being sent from the front-end
    • recentPageViewMode
    • samplesViewMode

Reviewers

@QilongTang
@Amoursol

FYIs

@reddyashish

- added a single serialized preferences storage for the HomePage
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang merged commit 534f6cf into DynamoDS:master Apr 16, 2024
22 of 23 checks passed
@QilongTang QilongTang added this to the 3.2 milestone Apr 16, 2024
@QilongTang
Copy link
Contributor

QilongTang commented Apr 16, 2024

Oops, I think I accidentally merged the wrong PR.. Will review now and depends on the result, we can see how to follow up

/// <summary>
/// Persistence for Dynamo HomePage
/// </summary>
[XmlIgnore]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Apr 16, 2024
reddyashish added a commit that referenced this pull request Apr 16, 2024
@QilongTang
Copy link
Contributor

@dnenov Would you re-propose this PR?

@reddyashish
Copy link
Contributor

I will create a new PR for this one as Deyan is going on leave.

@QilongTang
Copy link
Contributor

I will create a new PR for this one as Deyan is going on leave.

Thank you, appreciate it!

reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request May 14, 2024
- added a single serialized preferences storage for the HomePage

(cherry picked from commit 534f6cf)
reddyashish added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants