Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6857-homepage-preferences #13

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 16, 2024

Purpose

This PR addresses a jira request for improvement of the HomePage: As a Dynamo user, I want Grid/List view option picked on Dynamo Home persist across sessions https://jira.autodesk.com/browse/DYN-6857.

As a Dynamo user, I want Grid/List view option picked on Dynamo Home persist across sessions.

  • Needs to be serialized
  • Needs to persist across session
  • Do not require user to set initial value
  • Preferred to be migrated with newer version of Dynamo launch

We have examples in Preferences Settings just like this, e.g. Dynamo Window Default size, Dynamo Library Default size, etc. Although this setting is not expected to be exposed in settings panel

Works with the following proposed Dynamo changes: DynamoDS/Dynamo#15215

Changes

DynamoSandbox_rwEx2sI2K4

Changes

  • added preferences to track and persist across sessions the user preferences for the view mode of the Recent and Sample files
  • version bump

Reviewer

@QilongTang
@Amoursol

- added preferences to track and persist across sessions the user preferences for the view mode of the Recent and Sample files
@dnenov dnenov changed the title added viewMode preferences DYN-6857-homepage-preferences Apr 16, 2024
@dnenov dnenov requested a review from QilongTang April 17, 2024 10:04
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the conflicts.

@reddyashish reddyashish merged commit 8039173 into master May 14, 2024
11 checks passed
@reddyashish reddyashish deleted the DYN-6857-homepage-preferences branch May 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants