Add configuration option to persist empty strings as is #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
force-pushed
the
add-configuration-option-to-persist-empty-strings
branch
2 times, most recently
from
98cf17a
to
191ecff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 91.08% 91.18% +0.10%
==========================================
Files 71 73 +2
Lines 3453 3496 +43
==========================================
+ Hits 3145 3188 +43
Misses 308 308 ☔ View full report in Codecov by Sentry. |
Docker Compose V1 was deprecated and removed in GitHub Actions. See https://github.blog/changelog/2024-04-10-github-hosted-runner-images-deprecation-notice-docker-compose-v1/
andrykonchin
force-pushed
the
add-configuration-option-to-persist-empty-strings
branch
from
191ecff
to
4e20e64
Compare
andrykonchin
deleted the
add-configuration-option-to-persist-empty-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Config.store_empty_string_as_niloptions that is true by default. If it's true - empty strings will be persisted as nil otherwise as is. DynamoDB added support of storing empty strings so this logic isn't required anymore.Close #788