Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split up 'setup' task of Makefile #1242

Merged
merged 4 commits into from
Oct 19, 2023

chore: Move gotestsum install to separate task

2658978
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: Split up 'setup' task of Makefile #1242

chore: Move gotestsum install to separate task
2658978
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci succeeded Oct 19, 2023 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (17)

internal/featureflags/permanent.go|17| 17-82 lines are duplicate of internal/featureflags/temporary.go:17-84 (dupl)
internal/featureflags/temporary.go|17| 17-84 lines are duplicate of internal/featureflags/permanent.go:17-82 (dupl)
pkg/client/dtclient/client.go|321| 321-335 lines are duplicate of pkg/client/dtclient/client.go:351-365 (dupl)
pkg/client/dtclient/client.go|351| 351-365 lines are duplicate of pkg/client/dtclient/client.go:321-335 (dupl)
pkg/persistence/account/load.go|31 col 1| cognitive complexity 27 of func Load is high (> 25) (gocognit)
internal/template/parse.go|109 col 1| cognitive complexity 38 of func convert is high (> 25) (gocognit)
pkg/converter/converter.go|369 col 1| cognitive complexity 27 of func convertParameters is high (> 25) (gocognit)
internal/json/json.go|123| internal/json/json.go:123: Line contains TODO/BUG/FIXME: "TODO actually check against the model (g..." (godox)
pkg/manifest/manifest_loader.go|613| pkg/manifest/manifest_loader.go:613: Line contains TODO/BUG/FIXME: "TODO should we really fail here?" (godox)
pkg/config/parameter/list/list.go|35| pkg/config/parameter/list/list.go:35: Line contains TODO/BUG/FIXME: "TODO(CA-1517): allow for parameter.Param..." (godox)
pkg/config/parameter/list/list.go|50| pkg/config/parameter/list/list.go:50: Line contains TODO/BUG/FIXME: "TODO(CA-1517): implement handling of ref..." (godox)
pkg/config/parameter/list/list.go|83| pkg/config/parameter/list/list.go:83: Line contains TODO/BUG/FIXME: "TODO(CA-1517): call the underlying param..." (godox)
pkg/persistence/config/loader/parameters.go|140| pkg/persistence/config/loader/parameters.go:140: Line contains TODO/BUG/FIXME: "TODO come up with better way to handle t..." (godox)
pkg/persistence/config/writer/config_writer.go|349| pkg/persistence/config/writer/config_writer.go:349: Line contains TODO/BUG/FIXME: "TODO refactor this monstrosity" (godox)
pkg/graph/graph.go|245| pkg/graph/graph.go:245: Line contains TODO/BUG/FIXME: "TODO: to comply with the current 'contin..." (godox)
internal/json/json.go|119 col 14| type switch on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
pkg/persistence/config/internal/persistence/type_definition.go|29 col 6| TypeDefinition should be annotated with the mapstructure tag as it is passed to mapstructure.Decode at pkg/persistence/config/internal/persistence/type_definition.go:72:13 (musttag)