Update rubocop to a slightly less ancient version to allow us to use ruby-2.7 syntax #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofedoren not great, I admit, but I don't really have the determination to fix all gorillion cops that were added or changed since rubocop-0.39.0. On the brighter side, this should allow us to use the triple dot splat. |
ofedoren
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Thanks, @adamruzicka, love the changes :) The only question though:
| require 'apipie-params' | ||
| require 'algebrick' | ||
| require 'thread' |
There was a problem hiding this comment.
Just to make sure, this isn't being used, is it?
There was a problem hiding this comment.
We're using threads, but it seems to be auto-required. Or to put it the other way around, we don't seem to be using anything related to threads that we'd have to explicitly require
It would make certain algebrick constructs feel clunky.
…Indentation, Layout/ClosingParenthesisIndentation cops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.