-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop to a slightly less ancient version to allow us to use ruby-2.7 syntax #442
Conversation
@ofedoren not great, I admit, but I don't really have the determination to fix all gorillion cops that were added or changed since rubocop-0.39.0. On the brighter side, this should allow us to use the triple dot splat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adamruzicka, love the changes :) The only question though:
require 'apipie-params' | ||
require 'algebrick' | ||
require 'thread' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, this isn't being used, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using threads, but it seems to be auto-required. Or to put it the other way around, we don't seem to be using anything related to threads that we'd have to explicitly require
It would make certain algebrick constructs feel clunky.
…Indentation, Layout/ClosingParenthesisIndentation cops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adamruzicka, LGTM :)
No description provided.