Generalize MOAB map reading #7015
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/target/intx apps to be consistent
…r in-memory computation workflows
for easier interchange we need to compute a graph for read map too, similar to the oar comm graph for intersection, between the source and coverage use correct intersection context
… is turned on, seeing a blow up in Faxx variables
also, read the f map too, after the s map order is now important, because the area_b in the bilinear a2l map is wrong (it is 0) in the F a2l map, area_b is fine, so it wins over Also, a typo in reading the a2l S map, we were using mbrxid instead of mbaxid
need to investigate why I did it
it was failing to load for ne120 data ocean case, on 80 nodes
read_map attribute was used only for r2o map all maps can now be read, and we do not need to use map mesh migrate also, mb_rof_aream_computed is not needed anymore, we are reading aream from maps always, now (this was only for r2o map)
…l whether maps are computed offline or online. By default, CPL_COMPUTE_MAPS_ONLINE=.false. i.e., maps are loaded from disk, replicating behavior of MCT
…ine) GNU extension for negation
iulian787
force-pushed
the
vijaysm/read-maps-from-disk
branch
from
3c30e2c to
9dd121e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to switch beetween reading maps and computing them online in the MOAB coupler.