-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyPi publishing to kegg-pathways-completeness #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review, the code looks sensible to me. We need to format the code with black before the release.
If we want to support python < 3.10 we need to change the networkx version:
|
End of life for python 3.9 is september 2025, so a little over a year, worth it? |
I have added everything needed to make this tool publishable on PyPi. I added aliases for four scripts, including the two important ones
give_pathways.py
andplot_completeness_graphs.py
, but also the scripts needed for generating an hmmtable since those would probably get used in future pipelines.I haven't published the package to PyPi yet, but I built it locally and installed it from the wheel and it works fine as is. Let me know if anything else should be added (more aliases?) or vice versa if some of these wouldn't get used and can be removed. Once this PR is merged I'll publish it for the first time.