Refactoring the service to make it more generic #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- made the JSONExtData Generic (it accepts T as the type of its object) - we also had to make the SeqColExtendedData generic (The same T type) - Some methods had to become generic also, in order to achieve this goal - Some logic has been changed. In some methods, we seperated the processing of the stringTypeExtData and the IntegerTypeExtData.
Length integer type approach2
Full ingest refactor
Tests refactor
|
This seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to refactor the eva-seqcol implementation to make it more generic in terms of accepting any kind of attribute type (usually when talking about the level 2).
Other enhancements are still pending, but this version works pretty well for most of the use cases.