Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the service to make it more generic #66

Merged
merged 23 commits into from
Nov 21, 2023
Merged

Refactoring the service to make it more generic #66

merged 23 commits into from
Nov 21, 2023

Commits on Oct 17, 2023

  1. Making some classes generic 

    - made the JSONExtData Generic (it accepts T as the type of its object)
- we also had to make the SeqColExtendedData generic (The same T type)
- Some methods had to become generic also, in order to achieve this goal
- Some logic has been changed. In some methods, we seperated the processing of the stringTypeExtData and the IntegerTypeExtData.
    @waterflow80
    waterflow80 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    75fb1b9 View commit details
    Browse the repository at this point in the history

  2. refactored the comparing process

    @waterflow80
    waterflow80 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1fa5006 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. deleted unnecessary classes

    @waterflow80
    waterflow80 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    90e6403 View commit details
    Browse the repository at this point in the history

  2. updated the toString() method

    @waterflow80
    waterflow80 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8d726cd View commit details
    Browse the repository at this point in the history

  3. added a test case for the JSONExtData toString() method

    @waterflow80
    waterflow80 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    12c44a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Merge pull request #56 from waterflow80/length_integer_type_approach2 

    Length integer type approach2
    @waterflow80
    waterflow80 authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    829691f View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. added separate classes for each type (List<String> & List<Integer>

    @waterflow80
    waterflow80 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    9cccfee View commit details
    Browse the repository at this point in the history

  2. updated the SeqColLevelOneService

    @waterflow80
    waterflow80 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    c33f0ac View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. updated the toString() method

    @waterflow80
    waterflow80 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4220238 View commit details
    Browse the repository at this point in the history

  2. completed the refactoring for the full ingest process

    @waterflow80
    waterflow80 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5f3d81c View commit details
    Browse the repository at this point in the history

  3. removed an unnecessary error message

    @waterflow80
    waterflow80 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    476db53 View commit details
    Browse the repository at this point in the history

  4. removed unused method

    @waterflow80
    waterflow80 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    147c41d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge pull request #58 from waterflow80/full_ingest_refactor 

    Full ingest refactor
    @waterflow80
    waterflow80 authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    218f694 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. refactored the SeqColWriter

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ba6a1a8 View commit details
    Browse the repository at this point in the history

  2. tiny change: update method name

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ea132fc View commit details
    Browse the repository at this point in the history

  3. NCBISeqColDataSourceTest refactor

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d3b7ab1 View commit details
    Browse the repository at this point in the history

  4. SeqColExtendedDataServiceTest

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bbc110f View commit details
    Browse the repository at this point in the history

  5. SeqColLevelOneServiceTest

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    6c71897 View commit details
    Browse the repository at this point in the history

  6. SeqColLevelTwoServiceTest

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d6de703 View commit details
    Browse the repository at this point in the history

  7. SeqColServiceTest

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d4ab57c View commit details
    Browse the repository at this point in the history

  8. JSONExtDataTest

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b8e0766 View commit details
    Browse the repository at this point in the history

  9. some refactoring in main code base

    @waterflow80
    waterflow80 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7d81aa2 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Merge pull request #62 from waterflow80/tests-refactor 

    Tests refactor
    @waterflow80
    waterflow80 authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f5789e2 View commit details
    Browse the repository at this point in the history