-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating fates default parameter file to api 36.1 #2700
Conversation
@ CLM meeting we discussed adding in the new arctic PFT changes to this pr too. Is this going to happen before we merge? |
Update surface datasets: double tag of ctsm5.3.0 New surface datasets because of updates in PFT/LAI/soil-color datasets, as well as two fire datasets (AG fire, pearland and the glacier behavior dataset. Also bring in an updated "PPE informed, hand-tuned" parameter file. And turn on Li2024 fire method. Also updates to allow creating transient landuse timeseries files going back to 1700. Fix an important bug on soil fields that was there since ctsm5.2.0. This results in mkaurfdata_esmf giving identical answers with a change in number of processors. Add in creation of ne0np4.POLARCAP.ne30x4 surface datasets. Asides: Remove VIC fields from surface datasets and testing. Add version to the surface datasets. Update the fire emissions factor dataset for the fire emissions testing in CTSM. Remove the --hires_pft option from mksurfdata_esmf as we don't have the datasets for it. Also delete mkprocdata_map.
This is a temporary update to avoid NGEET/fates#1254 and should be removed once a fix comes in on the fates-side.
FATES-side testing ran into an issue (NGEET/fates#1254) last week, but we have a work around in place via f2f7535. I'm rerunning tests today and should be able to get to the |
This update incorporates multiple parameter file updates per NGEET/fates#1255
Same as ctsm5.3.001 I made an accidental merge and reverted it.
This is due to needing a new 16 pft historical flanduse_timeseries file. See ESCOMP#2810. Note this is the older fates harvest mode, not the newer raw LUH2 driven modes.
|
Testing on derecho is complete. Nearly all expected tests are B4B. All the DIFFs against baseline are for the fates tests and are expected. There was a build error for a
The Location: UPDATE: the above |
Regression testing on izumi is mostly complete. I'm seeing two test hit issue #2800, so I'm resubmitting those:
I also ran into #2801. Otherwise all expected non-fates tests are B4B. |
These two passed on resubmit. Testing is complete. Location: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good! Just two minor things in the ChangeLog/ChangeSum.
Description of changes
This set of changes simply updates the default parameter file pointer. This is a minor API change because, while no interface code has changed, the format of the new file has indeed changed.
To do:
Specific notes
Contributors other than yourself, if any: @JessicaNeedham @XiulinGao @mpaiao @glemieux @jenniferholm
CTSM Issues Fixed (include github issue #):
Fates 1211
Fixes #2783
Are answers expected to change (and if so in what way)?
FATES answers will change. FATES test suite has been run in a special parameter configurations previous to the PR to test B4Bness on fates side PRs.
Any User Interface Changes (namelist or namelist defaults changes)? New fates parameter file default.
Does this create a need to change or add documentation? No
Testing performed, if any: will do regular and fates testing