Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating fates default parameter file to api 36.1 #2700

Merged
merged 16 commits into from
Oct 7, 2024

Conversation

rgknox
Copy link
Collaborator

@rgknox rgknox commented Aug 15, 2024

Description of changes

This set of changes simply updates the default parameter file pointer. This is a minor API change because, while no interface code has changed, the format of the new file has indeed changed.

To do:

  • A new default file must be loaded to the svn server
  • ".gitmodules" must be updated with the tag (will do so when fates-side tag is created)
  • The submodule pointer of the new fates tag must be added

Specific notes

Contributors other than yourself, if any: @JessicaNeedham @XiulinGao @mpaiao @glemieux @jenniferholm

CTSM Issues Fixed (include github issue #):

Fates 1211
Fixes #2783

Are answers expected to change (and if so in what way)?

FATES answers will change. FATES test suite has been run in a special parameter configurations previous to the PR to test B4Bness on fates side PRs.

Any User Interface Changes (namelist or namelist defaults changes)? New fates parameter file default.

Does this create a need to change or add documentation? No

Testing performed, if any: will do regular and fates testing

@rgknox rgknox added the FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM label Aug 26, 2024
@wwieder
Copy link
Contributor

wwieder commented Aug 29, 2024

@ CLM meeting we discussed adding in the new arctic PFT changes to this pr too. Is this going to happen before we merge?

Update surface datasets: double tag of ctsm5.3.0

New surface datasets because of updates in PFT/LAI/soil-color datasets, as well as two fire datasets (AG fire, pearland and the glacier behavior dataset. Also bring in an updated "PPE informed, hand-tuned" parameter file. And turn on Li2024 fire method. Also updates to allow creating transient landuse timeseries files going back to 1700. Fix an important bug on soil fields that was there since ctsm5.2.0. This results in mkaurfdata_esmf giving identical answers with a change in number of processors. Add in creation of ne0np4.POLARCAP.ne30x4 surface datasets.

Asides: Remove VIC fields from surface datasets and testing. Add version to the surface datasets. Update the fire emissions factor dataset for the fire emissions testing in CTSM. Remove the --hires_pft option from mksurfdata_esmf as we don't have the datasets for it. Also delete mkprocdata_map.
This is a temporary update to avoid NGEET/fates#1254 and should be
removed once a fix comes in on the fates-side.
@glemieux
Copy link
Collaborator

glemieux commented Oct 2, 2024

FATES-side testing ran into an issue (NGEET/fates#1254) last week, but we have a work around in place via f2f7535. I'm rerunning tests today and should be able to get to the aux_clm tests as well.

@glemieux glemieux mentioned this pull request Oct 2, 2024
4 tasks
This update incorporates multiple parameter file updates per NGEET/fates#1255
Same as ctsm5.3.001

I made an accidental merge and reverted it.
This is due to needing a new 16 pft historical flanduse_timeseries file.
See ESCOMP#2810.  Note this is the older fates harvest mode, not the newer raw
LUH2 driven modes.
@glemieux
Copy link
Collaborator

glemieux commented Oct 4, 2024

aux_clm testing on izumi and derecho are underway.

@glemieux
Copy link
Collaborator

glemieux commented Oct 5, 2024

Testing on derecho is complete. Nearly all expected tests are B4B. All the DIFFs against baseline are for the fates tests and are expected.

There was a build error for a nvhpc compiler FatesColdSatPhen test that I hadn't seen before that I was able to clear up upon manually re-building the case:

317 NVFORTRAN-F-0004-Corrupt or Old Module file solarabsorbedtype.mod (/glade/u/home/glemieux/ctsm/components/cmeps/cime_config/../cesm/driver/esm.F90: 808)
318 NVFORTRAN/x86-64 Linux 24.3-0: compilation aborted
319 gmake: *** [/glade/u/home/glemieux/scratch/ctsm-tests/tests_1004-162240de/SMS.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_nvhpc.clm-FatesColdSatPhen.GC.1004-162240de_nvh/Depends.nvhpc:149: esm.o] Error     2

The ERS_Ly5_P128x1.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput--clm-matrixcnOn_ignore_warnings test failed because it hit the wall clock time. I'll increase the time to 2 hours and resubmit.

Location: /glade/derecho/scratch/glemieux/ctsm-tests/tests_1004-162240de/

UPDATE: the above matrixcnOn_ignore_warnings passed B4B upon resubmit.

@glemieux
Copy link
Collaborator

glemieux commented Oct 5, 2024

Regression testing on izumi is mostly complete. I'm seeing two test hit issue #2800, so I'm resubmitting those:

FAIL ERI_D_Ld9_P48x1.f10_f10_mg37.I2000Clm50BgcCru.izumi_nag.clm-reduceOutput RUN time=292
FAIL ERP_D_Ld9.f10_f10_mg37.I1850Clm60BgcCrop.izumi_nag.clm-clm60cam7LndTuningModeLDust RUN time=360

I also ran into #2801. Otherwise all expected non-fates tests are B4B.

@glemieux
Copy link
Collaborator

glemieux commented Oct 6, 2024

Regression testing on izumi is mostly complete. I'm seeing two test hit issue #2800, so I'm resubmitting those:

FAIL ERI_D_Ld9_P48x1.f10_f10_mg37.I2000Clm50BgcCru.izumi_nag.clm-reduceOutput RUN time=292
FAIL ERP_D_Ld9.f10_f10_mg37.I1850Clm60BgcCrop.izumi_nag.clm-clm60cam7LndTuningModeLDust RUN time=360

These two passed on resubmit. Testing is complete.

Location: /scratch/cluster/glemieux/ctsm-tests/tests_1004-160528iz

@ekluzek ekluzek assigned samsrabin and unassigned adrifoster Oct 7, 2024
@ekluzek ekluzek requested a review from samsrabin October 7, 2024 16:18
Copy link
Collaborator

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good! Just two minor things in the ChangeLog/ChangeSum.

doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeSum Outdated Show resolved Hide resolved
@samsrabin samsrabin merged commit f80f4c4 into ESCOMP:master Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM
Projects
Status: Done (non release/external)
Development

Successfully merging this pull request may close these issues.

Error in FatescoldLandUse testmod
5 participants