Register species from MICM #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacraigucar
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Minor comment -- We are trying to standardize the ordering of the error message and error code in CCPP (just for uniformity sake). The ordering that was decided upon is errmsg, errcode, mainly because the NOAA code base uses this ordering. See NCAR/ccpp-framework#574
done! |
nusbaume
approved these changes
Aug 7, 2024
mattldawson
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Aug 20, 2024
Uses updated CCPP-generated data to include scheme dependencies in the CAM-SIMA build. In draft until ESCOMP/atmospheric_physics#102 is merged. --------- Co-authored-by: Jesse Nusbaumer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers constituents and sets needed constituent properties from MICM configuration.
(reopened to merge to development branch)
Additionally:
returns error codes and messages from MUSICA functions using new error handling in MICM
creates a musica_ccpp module to act as a the CCPP interface and moves existing functionality to a musica_ccpp_micm module in preparation for adding TUV-x (we will use musica_ccpp_ as a prefix for all the MUSICA modules in this repo to prevent naming conflicts with MUSICA Fortran library modules)
updates build scripts for changes to MUSICA and CCPP framework
adds memory checking to MUSICA tests
closes #74