Add TUV-x height grid updates #134
Conversation
…d' into 95-update-tuvx-temp
|
|
||
| type(grid_t), intent(inout) :: height_grid | ||
| real(kind_phys), intent(in) :: host_midpoints(:) ! km | ||
| real(kind_phys), intent(in) :: host_edges(:) ! km |
There was a problem hiding this comment.
Is the term edge equivalent to interface? If so, can we use interface across the code base to enhance the consistency and readability?
| real(kind_phys), intent(in) :: host_edges(:) ! km | |
| real(kind_phys), intent(in) :: host_interface(:) ! km |
| num_columns = size(constituents, dim=1) | ||
| num_layers = size(constituents, dim=2) | ||
| num_constituents = size(constituents, dim=3) |
There was a problem hiding this comment.
Can we still do this when the intent of constituents is out?
There was a problem hiding this comment.
I think maybe the intent can be inout to get the dimension?
real(kind_phys), intent(inout) :: constituents(:,:,:) ! kg kg-1
There was a problem hiding this comment.
Using intent(inout) should definitely work here, and is probably the safest bet.
| num_columns = size(constituents, dim=1) | ||
| num_layers = size(constituents, dim=2) | ||
| num_constituents = size(constituents, dim=3) |
There was a problem hiding this comment.
| num_columns = size(constituents, dim=1) | |
| num_layers = size(constituents, dim=2) | |
| num_constituents = size(constituents, dim=3) | |
| num_columns = size(micm_constituents, dim=1) | |
| num_layers = size(micm_constituents, dim=2) | |
| num_constituents = size(micm_constituents, dim=3) |
Should it be this instead?
There was a problem hiding this comment.
Yeah I found this possibly confusing. The function reshape_into_ccpp_arr() takes 1-D micm array and reshape it into 3-D CCPP array. It doesn't seem straightforward to get the dimension of CCPP array from micm array because this function does not want to know the number of columns and layers that are set when MCIM species are registered. (unless we want to do this way) I made CCPP array with intent(inout) instead of intent(out) solely to get the dimensions for the array. Any thoughts on this? I was also questioning about this.
!> Reshape array (1D -> 3D) and convert type (c_double -> kind_phys)
subroutine reshape_into_ccpp_arr(micm_constituents, constituents)
Updates TUV-x height grid with CAM-SIMA state data before calculating rate constants.
Uses geopontential height values to calculate actual heights above sea level, as currently done in the CAMChem gas-phase chemistry module. If there is a better way to get these height values, we can update this PR.
Closes #94
Notes (Jiwon):
edgeswithinterface