-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make preprocessors mask_above/below_threshold, mask_inside/outside_range lazy #2169
Conversation
Methods: mask_below/above_threshold, mask_inside/outside_range
…e_threshold _mask.py: Exchanged cube.data with cube.core_data()
Replacing cube.data with cube.core_data
Codecov Report
@@ Coverage Diff @@
## main #2169 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 237 237
Lines 12826 12826
=======================================
Hits 11942 11942
Misses 884 884
|
hi @joergbenke many thanks for contributing! Could you please tell us what this PR does, by adding a description to it (the title could use with a bit more info too please), and also if there is any issue that this contributes towards or closes; also please make sure the boxes in the PR description are ticked - the ones that are relevant to this PR, otherwise the others that are not, should either be strike-thru-ed, or removed. Then I'll be happy to review it 🍻 |
I've adapted my pull request and did some minor corrections:
I hope everything is fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, @joergbenke! The changes look good to me. I also noticed the performance improvements by running test cases with distributed.LocalCluster
which could be run successfully with this branch but not with current main
. This PR follows our guidelines, it is ready to be merged 👍
Thanks @joergbenke for your contribution and @remi-kazeroni for reviewing! This can be merged! I also checked the corresponding boxes in #674, 4 more prepcessory lazy 🚀 |
Description
mask_outside_range have been daskified (substituting numpy with dask.array)
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
[ ] 🧪 and 🛠 Documentation is available[ ] 🛠 Any changed dependencies have been added or removed correctlyTo help with the number pull requests: