Review rose-app.conf files in recipe test workflow
#3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-gill
added
the
Recipe Test Workflow (RTW)
ehogan
requested changes
May 23, 2024
There was a problem hiding this comment.
This looks great @mo-gill, thank you very much! 🥳
Following my comment #3571 (comment), would it be possible to add a shellcheck check to the workflow to check the remaining Bash script in the RTW (esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/app/get_esmval/bin/clone_latest_esmval.sh), please?
esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/app/install_env_file/rose-app.conf
Show resolved
Hide resolved
esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/flow.cylc
Outdated
Show resolved
Hide resolved
ehogan
reviewed
May 23, 2024
esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/app/compare/rose-app.conf
Outdated
Show resolved
Hide resolved
ehogan
requested changes
Jun 17, 2024
ehogan
requested changes
Jun 21, 2024
esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/flow.cylc
Outdated
Show resolved
Hide resolved
esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/app/install_env_file/rose-app.conf
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should use rose-app.conf files to replace the purposes of BASH scripts for rose apps.
It should also reduce the exposure of environment variables to users.
rose-app.conffiles in recipe test workflow #3571Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.