Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review rose-app.conf files in recipe test workflow #3601

Merged
merged 51 commits into from
Jun 25, 2024
Merged

Review rose-app.conf files in recipe test workflow #3601

merged 51 commits into from
Jun 25, 2024

Commits on May 20, 2024

  1. #3571: Recplace compare script with conf.

    @mo-gill
    mo-gill committed May 20, 2024
    Configuration menu
    Copy the full SHA
    b79f432 View commit details
    Browse the repository at this point in the history

  2. #3571: reformatted with rose-config dump.

    @mo-gill
    mo-gill committed May 20, 2024
    Configuration menu
    Copy the full SHA
    1e28b09 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. #3571: Implement rose-config version of install_env_file.sh

    @mo-gill
    mo-gill committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c38566d View commit details
    Browse the repository at this point in the history

  2. #3571: Remove unnecessary source pull.

    @mo-gill
    mo-gill committed May 21, 2024
    Configuration menu
    Copy the full SHA
    34a5cf0 View commit details
    Browse the repository at this point in the history

  3. #3571: Move env variables from app to suite level.

    @mo-gill
    mo-gill committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3c80a9e View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. #3571: Remove .sh file to fix merge conflict.

    @mo-gill
    mo-gill committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a09ffb0 View commit details
    Browse the repository at this point in the history

  2. #3571: Correction to file path of an install folder.

    @mo-gill
    mo-gill committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d29a01b View commit details
    Browse the repository at this point in the history

  3. #3571: Correction of documentation.

    @mo-gill
    mo-gill committed May 22, 2024
    Configuration menu
    Copy the full SHA
    dcf671a View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. #3571: Add shellcheck to testing workflow.

    @mo-gill
    mo-gill committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e6f2074 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. #3571: Remove unnecessary comment.

    @mo-gill
    mo-gill committed May 28, 2024
    Configuration menu
    Copy the full SHA
    bba02df View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. #3571: Amend names of path variables.

    @mo-gill
    mo-gill committed May 29, 2024
    Configuration menu
    Copy the full SHA
    55bbf30 View commit details
    Browse the repository at this point in the history

  2. #3571: More adjustment of variable names.

    @mo-gill
    mo-gill committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0bba951 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. #3571: Change path and dir names.

    @mo-gill
    mo-gill committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7d1c535 View commit details
    Browse the repository at this point in the history

  2. #3571: Rename KGO dir environment variable.

    @mo-gill
    mo-gill committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6dc240d View commit details
    Browse the repository at this point in the history

  3. #3571: Lint all shell scripts.

    @mo-gill
    mo-gill committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4da101b View commit details
    Browse the repository at this point in the history

  4. #3571: Test to check shellcheck working in workflow.

    @mo-gill
    mo-gill committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4ef9133 View commit details
    Browse the repository at this point in the history

  5. #3571: Correction to my test.

    @mo-gill
    mo-gill committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    369ac7d View commit details
    Browse the repository at this point in the history

  6. #3571: Removing mock broken .sh files.

    @mo-gill
    mo-gill committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ee60d45 View commit details
    Browse the repository at this point in the history

  7. #3571: Correction of workflow name.

    @mo-gill
    mo-gill committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8fe236e View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. #3571: Ascertain working dir in workflow.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f481c1f View commit details
    Browse the repository at this point in the history

  2. #3571: Add cd to rtw and a mock broken test.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    896a0bd View commit details
    Browse the repository at this point in the history

  3. #3571: Attempt to get non-zero exit on shellcheck warnings.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    776a231 View commit details
    Browse the repository at this point in the history

  4. #3571: Remove mock broken test.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1996812 View commit details
    Browse the repository at this point in the history

  5. #3571: Modify test to check for warnings. Add mock tests.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5b8c0e1 View commit details
    Browse the repository at this point in the history

  6. #3571: Modify shellcheck test.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8eae9be View commit details
    Browse the repository at this point in the history

  7. #3571: Modify test to echo output.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cccf541 View commit details
    Browse the repository at this point in the history

  8. #3571: Remove mock broken scripts as shellcheck now working.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    90d5ed9 View commit details
    Browse the repository at this point in the history

  9. #3571: Correction to workflow task spelling.

    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    06374ab View commit details
    Browse the repository at this point in the history

  10. Merge branch 'recipe_test_workflow_prototype' of github.com:ESMValGro… 

    …up/ESMValTool into 3571_review_rose_app_conf_files
    @mo-gill
    mo-gill committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5f016dc View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. #3571: Reverse patch changes to env file.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5d6816a View commit details
    Browse the repository at this point in the history

  2. #3571: Test removing print output on non zeros.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    19412b7 View commit details
    Browse the repository at this point in the history

  3. #3571: Try set -x to troubleshoot shellcheck issues.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4bfdd6c View commit details
    Browse the repository at this point in the history

  4. #3571: Try as one long command.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    37ff826 View commit details
    Browse the repository at this point in the history

  5. #3571: Try changing variable name.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c848fab View commit details
    Browse the repository at this point in the history

  6. #3571: Change variable name back to output to check it still works.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    98a8de3 View commit details
    Browse the repository at this point in the history

  7. #3571: Add dummy test to check check-rtw workflow runs.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    d9c29a8 View commit details
    Browse the repository at this point in the history

  8. #3571: Try changing variable names again.

    @mo-gill
    mo-gill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f39b9e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. #3571: Add dummy file again to check workflow.

    @mo-gill
    mo-gill committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    cfcd24a View commit details
    Browse the repository at this point in the history

  2. #3571: Test with broken shell scripts.

    @mo-gill
    mo-gill committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e188f02 View commit details
    Browse the repository at this point in the history

  3. #3571: Remove dummy broken scripts.

    @mo-gill
    mo-gill committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0815666 View commit details
    Browse the repository at this point in the history

  4. #3571: Test removing shellcheck to see if workflow still prints conda… 

    … env.
    @mo-gill
    mo-gill committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b888455 View commit details
    Browse the repository at this point in the history

  5. #3571: Add dummy file.

    @mo-gill
    mo-gill committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5881f5e View commit details
    Browse the repository at this point in the history

  6. #3571: Remove dummy test as conda env printout seems to be standard w… 

    …orkflow logging.
    @mo-gill
    mo-gill committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8c5283f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'recipe_test_workflow_prototype' into 3571_review_rose_a… 

    …pp_conf_files
    @mo-gill
    mo-gill committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b81e59a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. #3571: Change workflow task name and remove spaces.

    @mo-gill
    mo-gill committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d8f33cc View commit details
    Browse the repository at this point in the history

  2. #3571: Rose config dump needed.

    @mo-gill
    mo-gill committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b0af8c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Revert "#3571: Rose config dump needed." 

    This reverts commit b0af8c2.
    @ehogan
    ehogan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cfc38ce View commit details
    Browse the repository at this point in the history

  2. #3571: rose config-dump requires the empty line after the comment

    @ehogan
    ehogan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3361ea6 View commit details
    Browse the repository at this point in the history

  3. #3571: Add a COMPARE family

    @ehogan
    ehogan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b120b47 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'recipe_test_workflow_prototype' into 3571_review_rose_a… 

    …pp_conf_files
    @ehogan
    ehogan authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ee7c423 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'recipe_test_workflow_prototype' into 3571_review_rose_a… 

    …pp_conf_files
    @ehogan
    ehogan authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e240ce2 View commit details
    Browse the repository at this point in the history