-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin cartopy<0.24 on v2.11.x release branch #3770
Conversation
Updated (pinned) dependencies:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks V! Doc build still fails due to #3762
Co-authored-by: Manuel Schlund <[email protected]>
Cheers Manu 🍺 yeah we'll have dev docs broken if we rerelease, but i'll just be a rebuild so we should be ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valeriupredoi @schlunma Why do we need another release just to pin cartopy? Wouldn't it be sufficient to just do a new build of the conda package?
Yes but I wanted to have it in the release branch too, so we are all covered |
Am not gonna release per se, via the GH/PyPI mechanism, just a rebuild on c-f but wanted to make sure all tests pass etc etc |
OK, sounds good. I was worried you were planning a new release just for this 🍻 |
Yeah, that's what I thought too 👍 |
ha no, am just doing things to account for any issues down the line - the lazy way of doing things, so I don't have to work more in case stuff breaks later 😁 |
Description
Porting #3768 into the release branch so we can extract a build=1
It may be necessary to have other dependencies pinned, that have evolved in the meantime. I will use the lock file for that, and will post the deps that I end up pinning in a comment below, in this PR 🍺