Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cartopy<0.24 on v2.11.x release branch #3770

Merged
merged 12 commits into from
Oct 14, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 11, 2024

Description

Porting #3768 into the release branch so we can extract a build=1

It may be necessary to have other dependencies pinned, that have evolved in the meantime. I will use the lock file for that, and will post the deps that I end up pinning in a comment below, in this PR 🍺

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Oct 11, 2024

Updated (pinned) dependencies:

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks V! Doc build still fails due to #3762

.github/workflows/test.yml Outdated Show resolved Hide resolved
@schlunma schlunma added this to the v2.11.0 milestone Oct 14, 2024
@valeriupredoi
Copy link
Contributor Author

Cheers Manu 🍺 yeah we'll have dev docs broken if we rerelease, but i'll just be a rebuild so we should be ok

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeriupredoi @schlunma Why do we need another release just to pin cartopy? Wouldn't it be sufficient to just do a new build of the conda package?

@valeriupredoi
Copy link
Contributor Author

Yes but I wanted to have it in the release branch too, so we are all covered

@valeriupredoi
Copy link
Contributor Author

Am not gonna release per se, via the GH/PyPI mechanism, just a rebuild on c-f but wanted to make sure all tests pass etc etc

@bouweandela
Copy link
Member

OK, sounds good. I was worried you were planning a new release just for this 🍻

@bouweandela bouweandela dismissed their stale review October 14, 2024 09:57

Question answered

@schlunma
Copy link
Contributor

Yes but I wanted to have it in the release branch too, so we are all covered

Yeah, that's what I thought too 👍

@valeriupredoi
Copy link
Contributor Author

OK, sounds good. I was worried you were planning a new release just for this 🍻

ha no, am just doing things to account for any issues down the line - the lazy way of doing things, so I don't have to work more in case stuff breaks later 😁

@valeriupredoi valeriupredoi merged commit 8e59f4d into v2.11.x Oct 14, 2024
6 of 8 checks passed
@valeriupredoi valeriupredoi deleted the pin_cartopy_on_v211branch branch October 14, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants