Update chain id arguments handling #129
Conversation
ghost
assigned 
README.md
Outdated
| @@ -44,7 +43,7 @@ FLAGS: | |||
|
|
|||
| OPTIONS: | |||
| -p, --base-path <base-path> Set path for chain storage | |||
| -c, --chain <chain> Sets a chain name [default: mainnet] | |||
| -c, --chain <chain> Sets a chain name [default: etc] | |||
There was a problem hiding this comment.
Because ETH and ETC can't share same name
There was a problem hiding this comment.
but ETH is ETH, not mainnet, it's different name. I mean it's ok to have etc as a synonym to mainnet, but it shouldn't eliminate mainnet, because it's what expected to use for mainnet
There was a problem hiding this comment.
ok, I see. Will make then prefix for specific blockchain (etc-..|eth-...) and leave as is for distinctive name.
cli.bats
Outdated
| @test "succeeds: --chain=mainnet new --security=high --name='Test account' --description='Some description'" { | ||
| run $EMERALD_CLI --chain=mainnet \ | ||
| @test "succeeds: --chain=etc-main new --security=high --name='Test account' --description='Some description'" { | ||
| run $EMERALD_CLI --chain=etc-main \ |
There was a problem hiding this comment.
Because ETH and ETC can't share same name
| | 31 | Rootstock testnet | rootstock-test | | ||
| | 42 | Kovan | kovan | | ||
| | 61 | Ethereum Classic mainnet | etc-main | | ||
| | 62 | Ethereum Classic testnet | etc-test | |
There was a problem hiding this comment.
geth uses morden, why vault has own testnet instead?
There was a problem hiding this comment.
ETH morden chain id is 2, ETC morden - 62
There was a problem hiding this comment.
should (or is?) CLI argument etc be synonym for etc-main?
like eth is implicit for eth-main?
There was a problem hiding this comment.
and let's use mainet/testnet instead of main/test, to avoid confusion. I mean etc-mainnet (as a synonym to simple mainnet), not etc-main which will be a totally new name
Add new chain id/name to CLI (ETH related)
Related to #128