Skip to content

[bug] Fix bad JSON property for estimated delivery date #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2023
Merged

[bug] Fix bad JSON property for estimated delivery date #506

merged 2 commits into from
Aug 17, 2023

Conversation

nwithan8
Copy link
Contributor

Description

Testing

  • Tests updated to check for value of time-in-transit data to verify valid JSON deserialization
    • All tests pass, no re-recording needed.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team August 16, 2023 23:35
@nwithan8 nwithan8 linked an issue Aug 16, 2023 that may be closed by this pull request
[Bug]: TimeInTransitDetails.EasyPostEstimatedDeliveryDate has incorrect JSON name mapping #505
Closed
ranebo
ranebo approved these changes Aug 17, 2023
View reviewed changes
Copy link

@ranebo ranebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Justintime50
Justintime50 approved these changes Aug 17, 2023
View reviewed changes
@nwithan8 nwithan8 merged commit eb55628 into master Aug 17, 2023
@nwithan8 nwithan8 deleted the 505-bug-timeintransitdetailseasypostestimateddeliverydate-has-incorrect-json-name-mapping branch August 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranebo ranebo ranebo approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TimeInTransitDetails.EasyPostEstimatedDeliveryDate has incorrect JSON name mapping
3 participants
@nwithan8 @ranebo @Justintime50