Skip to content

[bug] Fix bad JSON property for estimated delivery date #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023
Merged

[bug] Fix bad JSON property for estimated delivery date #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ffc2bd
- Fix bad JSON property for estimated delivery date
nwithan8 Aug 16, 2023
4cdb9a0
- Update unit tests to verify correct JSON deserialization of time in…
nwithan8 Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions EasyPost.Tests/ServicesTests/ShipmentServiceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ public async Task TestAllParameterHandOff()
const bool includeChildren = true;
const bool purchased = false;

Dictionary<string, object> filters = new Dictionary<string, object> {
Dictionary<string, object> filters = new Dictionary<string, object>
{
{ "include_children", includeChildren },
{ "purchased", purchased },
};
Expand Down Expand Up @@ -208,7 +209,8 @@ public async Task TestGetNextPageParameterHandOff()
const bool includeChildren = true;
const bool purchased = false;

Dictionary<string, object> filters = new Dictionary<string, object> {
Dictionary<string, object> filters = new Dictionary<string, object>
{
{ "include_children", includeChildren },
{ "purchased", purchased },
};
Expand Down Expand Up @@ -598,6 +600,9 @@ public async Task TestRetrieveEstimatedDeliveryDates()
foreach (var rate in ratesWithEstimatedDeliveryDates)
{
Assert.NotNull(rate.EasyPostTimeInTransitData);
Assert.NotNull(rate.EasyPostTimeInTransitData.EasyPostEstimatedDeliveryDate);
Assert.NotNull(rate.EasyPostTimeInTransitData.DaysInTransit);
Assert.NotNull(rate.EasyPostTimeInTransitData.PlannedShipDate);
}
}

Expand Down
3 changes: 3 additions & 0 deletions EasyPost.Tests/ServicesTests/WithParameters/ShipmentServiceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,9 @@ public async Task TestRetrieveEstimatedDeliveryDates()
foreach (var rate in ratesWithEstimatedDeliveryDates)
{
Assert.NotNull(rate.EasyPostTimeInTransitData);
Assert.NotNull(rate.EasyPostTimeInTransitData.EasyPostEstimatedDeliveryDate);
Assert.NotNull(rate.EasyPostTimeInTransitData.DaysInTransit);
Assert.NotNull(rate.EasyPostTimeInTransitData.PlannedShipDate);
}
}

Expand Down
6 changes: 2 additions & 4 deletions EasyPost/Models/API/RateWithEstimatedDeliveryDate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ public class RateWithEstimatedDeliveryDate
public TimeInTransitDetails? EasyPostTimeInTransitData { get; set; }

#endregion

}

/// <summary>
Expand All @@ -42,8 +41,8 @@ public class TimeInTransitDetails
/// <summary>
/// EasyPost's estimated delivery date for the associated <see cref="RateWithEstimatedDeliveryDate"/>.
/// </summary>
[JsonProperty("easypost_time_in_transit_data")]
public string? EasyPostEstimatedDeliveryDate { get; set; }
[JsonProperty("easypost_estimated_delivery_date")]
public DateTime? EasyPostEstimatedDeliveryDate { get; set; }

/// <summary>
/// The planned departure date for the shipment.
Expand All @@ -52,6 +51,5 @@ public class TimeInTransitDetails
public DateTime? PlannedShipDate { get; set; }

#endregion

}
}