-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Conversation
Hello! In taking a look at this, I have some concerns about If we are adding this to the project, it seems we will need to commit to updates ourselves so may want to consider another path. Thoughts @eddiejaoude ? I checked through the conversation in the issue where this was also brought up, but unclear if this repo was approved for use |
I agree @amandamartin-dev the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The styled-qr-code
doesn't look like it is maintained, are there other alternatives that are still active?
Found this, looks good and is still maintained, and it's better because it's made for nextjs |
Thanks for the suggestion. I'll look into this library. |
I've created a new PR #9196 using the next-qrcode library. There are less options to configure the qrcode but it still works. Most noticeably will be the lack of margin around the logo. Can close this PR if the team decides to go with the other one instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you have created a new PR you can close this pull request.
@sital002 closing duplicate PRs would usually be the way forward. However in this case the PRs are not duplicates but different alternatives offered by the author - so we will leave both PRs open for now. |
Thank you @ckelwin for the great work and awesome collaboration everyone! 👍 But I think we should close this for now. |
Fixes Issue
Closes #8640
Changes proposed
styled-qr-code
libraryqrcode.react
from packageCheck List (Check all the applicable boxes)
Screenshots
Updated styled QR:
Downloaded qr code still works:
Note to reviewers
https://github.com/ckelwin/BioDrop/blob/8640-styled-qr-codes/components/QRStyledCanvas.js#L4-L18