Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Fixes EddieHubCommunity/BioDrop#8640 Updated QR to use next-qrcode. #9196

Closed
wants to merge 1 commit into from

Conversation

ckelwin
Copy link

@ckelwin ckelwin commented Sep 28, 2023

Fixes Issue

Closes #8640

Changes proposed

  • Added next-qrcode library
  • Removed qrcode.react from package
  • Updated the generated qr with some basic styling

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Downloaded qr code still works:
biodrop-eddiejaoude

Note to reviewers

  • This PR is a result of comments in PR Updated to use styled QR codes #9155. May close the other PR if the team decides to keep this.
  • Currently, the image displayed in qr code is currently hardcoded. Would be something we want to make configurable for users when editing their profile. A separate issue?
  • Not sure if this requires any documentation changes.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file issue linked Pull Request has issue linked labels Sep 28, 2023
@ckelwin ckelwin mentioned this pull request Sep 28, 2023
6 tasks
Copy link
Contributor

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SaraJaoude
Copy link
Member

Thank you @ckelwin for giving us an alternative. However given the lack of margin around the logo this makes unclear. I will close this PR and the maintainers will discuss your other PR (#9155).

@SaraJaoude SaraJaoude closed this Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] styled QR codes
3 participants