added test_user_script_crash test (#709) #777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detects if a by-design crashing black-box script Traceback is visible in the stderr output of orion.
bouthilx
reviewed
Feb 2, 2022
| def test_user_script_crash(capfd): | ||
| """Checks that the Traceback of a crashing user script is output to stderr""" | ||
|
|
||
| orion.core.cli.main( |
There was a problem hiding this comment.
The test if failing because the script is not found. Pytest is executed from the root so it cannot find this file at the root. You can use monkeypatch to change the working dir temporarily: https://github.com/Epistimio/orion/blob/develop/tests/functional/commands/conftest.py#L61
Note, the first test of this module is not crashing because it has the fixture one_experiment which does this change of working directory.
bouthilx
reviewed
Feb 2, 2022
bouthilx
reviewed
Feb 2, 2022
| "-c", | ||
| "-x~uniform(-5,5)", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
You could test the exit-code at the same time. The main should return it.
Co-authored-by: Xavier Bouthillier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detects if a by-design crashing black-box script Traceback is visible in the stderr output of orion.
The test succeeds, which indicates that the stacktrace is indeed visible by the user on his terminal output.
Is meant to implement issue #709
Changes
Just a test, since the behaviour is already good.
Added a "black box" utility script that can return a code passed by argument, and/or crash if -c argument is specified.
Checklist
Tests
$ tox -e py38; replace38by your Python version if necessary)Documentation
Quality
$ tox -e lint)Further comments
n/a