-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added test_user_script_crash test (#709) #777
Open
nurbal
wants to merge
2
commits into
Epistimio:develop
Choose a base branch
from
nurbal:feature/709_improve-error-msg-on-script-failure
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
#!/usr/bin/env python | ||
# -*- coding: utf-8 -*- | ||
"""User script that exits with code given in argument.""" | ||
import argparse | ||
import sys | ||
from xmlrpc.client import boolean | ||
|
||
|
||
def execute(): | ||
"""Execute a simple pipeline as an example.""" | ||
# 1. Get the wanted exit code | ||
parser = argparse.ArgumentParser() | ||
parser.add_argument( | ||
"--exitcode", "-e", type=int, default=0, help="wanted exit code" | ||
) | ||
parser.add_argument( | ||
"--crash", "-c", action="store_true", help="make a crash happen" | ||
) | ||
parser.add_argument("-x", type=float, required=True) | ||
inputs = parser.parse_args() | ||
|
||
# 2. if needed, crash ! | ||
if inputs.crash: | ||
print("%b" % False) # black_box_fail.py : this line should crash | ||
|
||
# 3. exit with the wanted code | ||
sys.exit(inputs.exitcode) | ||
|
||
|
||
if __name__ == "__main__": | ||
execute() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,3 +35,26 @@ def test_no_name(capsys): | |
captured = capsys.readouterr().err | ||
|
||
assert captured == "Error: No name provided for the experiment.\n" | ||
|
||
|
||
def test_user_script_crash(capfd): | ||
"""Checks that the Traceback of a crashing user script is output to stderr""" | ||
|
||
orion.core.cli.main( | ||
[ | ||
"--debug", | ||
"hunt", | ||
"-n", | ||
"test", | ||
"--exp-max-trials", | ||
nurbal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"1", | ||
"./black_box_fail.py", | ||
"-c", | ||
"-x~uniform(-5,5)", | ||
] | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could test the exit-code at the same time. The |
||
|
||
out, err = capfd.readouterr() | ||
|
||
assert "Traceback" in err | ||
assert "# black_box_fail.py : this line should crash" in err |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test if failing because the script is not found. Pytest is executed from the root so it cannot find this file at the root. You can use monkeypatch to change the working dir temporarily: https://github.com/Epistimio/orion/blob/develop/tests/functional/commands/conftest.py#L61
Note, the first test of this module is not crashing because it has the fixture
one_experiment
which does this change of working directory.