Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve allocation evaluation details for ASSIGNMENT_ERROR #118

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

greghuels
Copy link
Contributor

@greghuels greghuels commented Jul 31, 2024

Fix for test updates in Eppo-exp/sdk-test-data#49. Tests will pass once that PR is merged.

@greghuels greghuels requested a review from rasendubi July 31, 2024 12:47
src/evaluator.ts Outdated Show resolved Hide resolved
src/client/eppo-client.ts Show resolved Hide resolved
@greghuels greghuels force-pushed the greg/preserve-allocation-details-on-error branch 4 times, most recently from febd96b to 4026acc Compare August 2, 2024 17:31
@greghuels greghuels force-pushed the greg/preserve-allocation-details-on-error branch from 429758d to 73b4aa1 Compare August 2, 2024 18:41
Copy link
Collaborator

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@greghuels greghuels merged commit ae6bfde into main Aug 2, 2024
2 checks passed
@greghuels greghuels deleted the greg/preserve-allocation-details-on-error branch August 2, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants