fix: preserve allocation evaluation details when ASSIGNMENT_ERROR #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASSIGNMENT_ERROR later in the evaluation process should not revert the previously-done evaluation and definitely should not list unmatched/matched allocations as "unevaluated."
rasendubi
force-pushed
the
fix-preserve-evaluation-details-on-error
branch
from
364ea92
to
1a00648
Compare
This was referenced Jul 29, 2024
greghuels
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks for catching this! I have the JS/SDK fix implemented in Eppo-exp/js-client-sdk-common#118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASSIGNMENT_ERROR later in the evaluation process should not revert the previously-done evaluation and definitely should not list unmatched/matched allocations as "unevaluated."