Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/layout mode + wacom support staging #214

Open
wants to merge 20 commits into
base: staging
Choose a base branch
from

Conversation

elliot2
Copy link

@elliot2 elliot2 commented Nov 12, 2024

Hi @Esshahn

Here is the same again, however with the layout mode as just number inputs. ie, so the user can just define the layout :

image

eg. 4 x 1 :

image

@Esshahn
Copy link
Owner

Esshahn commented Nov 12, 2024

Pretty awesome!
Some observations:

  • On Safari, the up/down form buttons of the input fields are misaligned
Bildschirmfoto 2024-11-12 um 14 26 28
  • when in multi-sprite view, only the sprite color of the first sprite is used, not the individual sprite color (note that the second sprite should be yellow here)

  • the grid setup gets lost when clicking on a sprite which has no following sprites. To reproduce with the image example above:

    1. click on sprite 1 and set the grid to 4x1.
    1. click on sprite 4.
    1. click on sprite 1 again
  • result: grid is reset to 1x1 again

If think it's because there would not be any sprite to display if e.g. we are looking at the last sprite. Maybe we could force the grid view and if there's nothing to display, show an empty grayed out area? That way the UI would stay consistent and the user would not need to readjust the grid, what do you think?

@Esshahn
Copy link
Owner

Esshahn commented Nov 12, 2024

had to move around the css files since there was a loading issue, hence the conflict.

@elliot2
Copy link
Author

elliot2 commented Nov 13, 2024

Ah yes, I'll take a look at the individual color thing tonight.

I think the safari thing might be a bit of a challenge as I am not running on a mac at the moment. Are you able to strip off some of the styling and see if it helps, I was trying to get a dark theme.

@Esshahn
Copy link
Owner

Esshahn commented Nov 13, 2024

Individual sprite color now works great!

@elliot2
Copy link
Author

elliot2 commented Nov 13, 2024

Ok, cool. Also I made an adjustment for the grid division depending on if it is a multi layout :
image

@Esshahn
Copy link
Owner

Esshahn commented Nov 13, 2024

love it!

@elliot2
Copy link
Author

elliot2 commented Nov 13, 2024

This change will mean the layout does not need to be reset each time.
image

@elliot2 elliot2 changed the title Feature/layout mode staging Feature/layout mode + wacom support staging Nov 14, 2024
@Esshahn
Copy link
Owner

Esshahn commented Nov 16, 2024

Found a bug: when entering a number in the layout input field, the number 1 gets added.

Reproduce (Safari & Chrome):

  1. Start with a normal 1x1 layout
  2. Click into the first input field
  3. delete the 1
  4. enter 2
  5. Result: Number 12 is shown
  6. Expected: Number 2 is shown

Additionally, I'd suggest we remove the up/down buttons from the input fields for now as they are quite big and do not work on safari yet. I think we're fine without them, too.
Bildschirmfoto 2024-11-16 um 17 54 20
Bildschirmfoto 2024-11-16 um 17 54 27
Bildschirmfoto 2024-11-16 um 17 54 32

@Esshahn
Copy link
Owner

Esshahn commented Nov 16, 2024

Minor: noticed that the "x" is not centered between the input fields
Bildschirmfoto 2024-11-16 um 18 00 43

@elliot2
Copy link
Author

elliot2 commented Nov 17, 2024

image
Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants