Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add parquet support #3360

Merged
merged 2 commits into from
Dec 11, 2024

fix some of Colin's requests

4a1d365
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): add parquet support #3360

fix some of Colin's requests
4a1d365
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 0s

77.68% (+1.56%) compared to e5ea73f

View this Pull Request on Codecov

77.68% (+1.56%) compared to e5ea73f

Details

Codecov Report

Attention: Patch coverage is 80.34682% with 34 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (e5ea73f) to head (4a1d365).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/op/execute/write.rs 78.31% 18 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 76.19% 5 Missing ⚠️
.../daft-connect/src/translation/logical_plan/read.rs 73.68% 5 Missing ⚠️
...t/src/translation/logical_plan/read/data_source.rs 84.37% 5 Missing ⚠️
...daft-connect/src/translation/logical_plan/to_df.rs 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
+ Coverage   76.11%   77.68%   +1.56%     
==========================================
  Files         710      713       +3     
  Lines       89196    87091    -2105     
==========================================
- Hits        67894    67657     -237     
+ Misses      21302    19434    -1868     
Files with missing lines Coverage Δ
src/daft-connect/src/lib.rs 68.57% <100.00%> (+2.22%) ⬆️
src/daft-connect/src/op/execute.rs 80.95% <ø> (ø)
src/daft-connect/src/op/execute/root.rs 95.65% <100.00%> (+0.19%) ⬆️
...-connect/src/translation/logical_plan/aggregate.rs 81.81% <100.00%> (ø)
...ft-connect/src/translation/logical_plan/project.rs 88.88% <100.00%> (ø)
...nnect/src/translation/logical_plan/with_columns.rs 94.73% <100.00%> (ø)
src/daft-connect/src/translation/schema.rs 100.00% <ø> (ø)
...daft-connect/src/translation/logical_plan/to_df.rs 90.00% <75.00%> (-4.74%) ⬇️
src/daft-connect/src/translation/logical_plan.rs 69.23% <76.19%> (-3.94%) ⬇️
.../daft-connect/src/translation/logical_plan/read.rs 73.68% <73.68%> (ø)
... and 2 more

... and 31 files with indirect coverage changes