Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add parquet support #3360

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

andrewgazelka
Copy link
Member

@andrewgazelka andrewgazelka commented Nov 20, 2024

No description provided.

Copy link
Member Author

andrewgazelka commented Nov 20, 2024

@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from 40e4b48 to f679598 Compare November 20, 2024 10:34
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 863ac08 to c999ae9 Compare November 20, 2024 18:24
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from f679598 to 90ba716 Compare November 20, 2024 18:25
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from c999ae9 to 394c381 Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from 90ba716 to e8b1315 Compare November 20, 2024 18:33
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 394c381 to 3fb2d4f Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from e8b1315 to d769d56 Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 3fb2d4f to 4f49d30 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from d769d56 to a3217f3 Compare November 20, 2024 18:49
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 4f49d30 to e95abbd Compare November 20, 2024 19:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from a3217f3 to 4248e5c Compare November 20, 2024 19:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from e95abbd to 0e54699 Compare November 20, 2024 22:12
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from 4248e5c to bcccee0 Compare November 20, 2024 22:14
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 0e54699 to cdcd749 Compare November 20, 2024 23:28
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from bcccee0 to a5c1596 Compare November 20, 2024 23:29
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #3360 will degrade performances by 39.79%

Comparing andrew/connect-parquet3 (4a1d365) with main (f23ee37)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-parquet3 Change
test_iter_rows_first_row[100 Small Files] 189.2 ms 314.3 ms -39.79%
test_show[100 Small Files] 23.8 ms 16.1 ms +47.64%

@andrewgazelka andrewgazelka marked this pull request as draft November 26, 2024 13:57
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch 2 times, most recently from c217242 to 9c3d5ed Compare November 27, 2024 07:36
@andrewgazelka andrewgazelka marked this pull request as ready for review November 27, 2024 07:40
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from 9c3d5ed to 7514d37 Compare November 27, 2024 07:41
@andrewgazelka andrewgazelka changed the title [FEAT] connect: add parquet support [FEAT] 🚧🚧🚧 connect: add parquet support BLOCKED Nov 27, 2024
@andrewgazelka andrewgazelka marked this pull request as draft November 27, 2024 19:00
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch 7 times, most recently from 948f6dd to 1f6d6b2 Compare December 10, 2024 06:24
@andrewgazelka andrewgazelka changed the title [FEAT] 🚧🚧🚧 connect: add parquet support BLOCKED [FEAT] connect: add parquet support BLOCKED Dec 10, 2024
@andrewgazelka andrewgazelka changed the title [FEAT] connect: add parquet support BLOCKED feat(connect): add parquet support Dec 10, 2024
@github-actions github-actions bot added the feat label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 80.34682% with 34 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (e5ea73f) to head (4a1d365).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/op/execute/write.rs 78.31% 18 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 76.19% 5 Missing ⚠️
.../daft-connect/src/translation/logical_plan/read.rs 73.68% 5 Missing ⚠️
...t/src/translation/logical_plan/read/data_source.rs 84.37% 5 Missing ⚠️
...daft-connect/src/translation/logical_plan/to_df.rs 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
+ Coverage   76.11%   77.68%   +1.56%     
==========================================
  Files         710      713       +3     
  Lines       89196    87091    -2105     
==========================================
- Hits        67894    67657     -237     
+ Misses      21302    19434    -1868     
Files with missing lines Coverage Δ
src/daft-connect/src/lib.rs 68.57% <100.00%> (+2.22%) ⬆️
src/daft-connect/src/op/execute.rs 80.95% <ø> (ø)
src/daft-connect/src/op/execute/root.rs 95.65% <100.00%> (+0.19%) ⬆️
...-connect/src/translation/logical_plan/aggregate.rs 81.81% <100.00%> (ø)
...ft-connect/src/translation/logical_plan/project.rs 88.88% <100.00%> (ø)
...nnect/src/translation/logical_plan/with_columns.rs 94.73% <100.00%> (ø)
src/daft-connect/src/translation/schema.rs 100.00% <ø> (ø)
...daft-connect/src/translation/logical_plan/to_df.rs 90.00% <75.00%> (-4.74%) ⬇️
src/daft-connect/src/translation/logical_plan.rs 69.23% <76.19%> (-3.94%) ⬇️
.../daft-connect/src/translation/logical_plan/read.rs 73.68% <73.68%> (ø)
... and 2 more

... and 31 files with indirect coverage changes

@andrewgazelka andrewgazelka marked this pull request as ready for review December 10, 2024 08:12
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from 5e65a85 to 0c6b7c8 Compare December 10, 2024 23:52
@andrewgazelka andrewgazelka force-pushed the andrew/connect-parquet3 branch from 8108892 to d719dfe Compare December 11, 2024 00:40
src/daft-connect/src/op/execute/write.rs Show resolved Hide resolved
tests/connect/test_parquet.py Outdated Show resolved Hide resolved
tests/connect/test_parquet.py Outdated Show resolved Hide resolved
@andrewgazelka andrewgazelka merged commit c057493 into main Dec 11, 2024
43 of 44 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-parquet3 branch December 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants