Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: support basic column operations #3362

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

andrewgazelka
Copy link
Member

@andrewgazelka andrewgazelka commented Nov 20, 2024

Works:

Column.alias(*alias, **kwargs)
Column.cast(dataType)
Column.isNotNull()
Column.isNull()
Column.name(*alias, **kwargs) (= name)

Copy link
Member Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from c0f0a0a to 22d7e93 Compare November 20, 2024 10:57
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 863ac08 to c999ae9 Compare November 20, 2024 18:24
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 22d7e93 to 83f2117 Compare November 20, 2024 18:25
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from c999ae9 to 394c381 Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 83f2117 to df7ffd5 Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 394c381 to 3fb2d4f Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from df7ffd5 to 5c5279f Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 3fb2d4f to 4f49d30 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 5c5279f to ba57801 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 4f49d30 to e95abbd Compare November 20, 2024 19:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from ba57801 to 81ff3b6 Compare November 20, 2024 19:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from e95abbd to 0e54699 Compare November 20, 2024 22:12
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 81ff3b6 to 5ddc229 Compare November 20, 2024 22:12
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 0e54699 to cdcd749 Compare November 20, 2024 23:28
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 5ddc229 to 470d2de Compare November 20, 2024 23:28
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 470d2de to 89e89e8 Compare November 20, 2024 23:40
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 89e89e8 to 36a8d0c Compare November 21, 2024 00:13
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 1657f1d to 000fc66 Compare November 21, 2024 05:14
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3362 to main November 21, 2024 05:15
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch 2 times, most recently from 5bfb232 to f6ff23a Compare November 21, 2024 05:16
@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2024
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #3362 will improve performances by 54.69%

Comparing andrew/connect-column-operations (a0165a6) with main (83470e0)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main andrew/connect-column-operations Change
test_iter_rows_first_row[100 Small Files] 283.1 ms 238.6 ms +18.65%
test_show[100 Small Files] 25.8 ms 16.7 ms +54.69%

Copy link

graphite-app bot commented Nov 21, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 25.44379% with 126 lines in your changes missing coverage. Please review.

Project coverage is 77.33%. Comparing base (83470e0) to head (a0165a6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/datatype.rs 7.96% 104 Missing ⚠️
src/daft-connect/src/translation/expr.rs 50.00% 18 Missing ⚠️
...onnect/src/translation/expr/unresolved_function.rs 80.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3362      +/-   ##
==========================================
- Coverage   77.39%   77.33%   -0.06%     
==========================================
  Files         696      696              
  Lines       84549    84716     +167     
==========================================
+ Hits        65438    65517      +79     
- Misses      19111    19199      +88     
Files with missing lines Coverage Δ
src/daft-connect/src/lib.rs 64.21% <ø> (ø)
...onnect/src/translation/expr/unresolved_function.rs 64.70% <80.00%> (+64.70%) ⬆️
src/daft-connect/src/translation/expr.rs 57.14% <50.00%> (+1.00%) ⬆️
src/daft-connect/src/translation/datatype.rs 10.40% <7.96%> (+2.99%) ⬆️

... and 4 files with indirect coverage changes

@andrewgazelka andrewgazelka requested review from universalmind303 and removed request for desmondcheongzx November 27, 2024 07:41
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from ca4d137 to 2c7437d Compare November 27, 2024 07:42
@andrewgazelka andrewgazelka requested review from jaychia and removed request for universalmind303 November 27, 2024 21:11
Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM, added some comments but mostly questions.

Please do address the comment on # Test cast though.

src/daft-connect/src/translation/datatype.rs Show resolved Hide resolved
src/daft-connect/src/translation/datatype.rs Show resolved Hide resolved
src/daft-connect/src/translation/expr.rs Outdated Show resolved Hide resolved
src/daft-connect/src/translation/expr.rs Show resolved Hide resolved
src/daft-connect/src/translation/expr.rs Show resolved Hide resolved
tests/connect/test_basic_column.py Outdated Show resolved Hide resolved
tests/connect/test_basic_column.py Show resolved Hide resolved
tests/connect/test_basic_column.py Outdated Show resolved Hide resolved
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch 2 times, most recently from 348c5e9 to 67bb5fe Compare December 4, 2024 02:05
@andrewgazelka andrewgazelka force-pushed the andrew/connect-column-operations branch from 67bb5fe to a0165a6 Compare December 4, 2024 02:08
@andrewgazelka andrewgazelka merged commit caf0626 into main Dec 4, 2024
44 of 45 checks passed
Copy link
Member Author

Merge activity

  • Dec 3, 9:32 PM EST: A user merged this pull request with Graphite.

@andrewgazelka andrewgazelka deleted the andrew/connect-column-operations branch December 4, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants