Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add df.filter #3346

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat(connect): add df.filter #3346

merged 1 commit into from
Dec 11, 2024

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 06:44
Copy link
Contributor Author

andrewgazelka commented Nov 20, 2024

@andrewgazelka andrewgazelka changed the base branch from andrew/connect-alias to andrew/connect-binary-operators November 20, 2024 07:16
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch 2 times, most recently from 81d6894 to 28e0edf Compare November 20, 2024 09:04
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 28e0edf to b399d76 Compare November 20, 2024 09:45
@andrewgazelka andrewgazelka force-pushed the andrew/connect-filter branch 2 times, most recently from 2927f5e to f3ee658 Compare November 20, 2024 09:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from b399d76 to 0eb7089 Compare November 20, 2024 09:52
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 0eb7089 to b09fc18 Compare November 20, 2024 11:19
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from b09fc18 to 0849d25 Compare November 20, 2024 18:25
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 0849d25 to eb1c9af Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from eb1c9af to 4bf4495 Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from fbc5c6e to a2e0beb Compare December 4, 2024 02:09
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch 2 times, most recently from b9a7f70 to 3ee5757 Compare December 4, 2024 02:33
@andrewgazelka andrewgazelka force-pushed the andrew/connect-filter branch 2 times, most recently from 6fcc1dd to 315a449 Compare December 4, 2024 02:45
Base automatically changed from andrew/connect-binary-operators to main December 4, 2024 03:01
@github-actions github-actions bot added the enhancement New feature or request label Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #3346 will degrade performances by 52.34%

Comparing andrew/connect-filter (fecfc7d) with main (c3088d6)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-filter Change
test_iter_rows_first_row[100 Small Files] 105.9 ms 222.2 ms -52.34%

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.67%. Comparing base (c3088d6) to head (fecfc7d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...aft-connect/src/translation/logical_plan/filter.rs 81.81% 2 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3346   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files         713      714    +1     
  Lines       87116    87130   +14     
=======================================
+ Hits        67670    67681   +11     
- Misses      19446    19449    +3     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 69.09% <66.66%> (-0.14%) ⬇️
...aft-connect/src/translation/logical_plan/filter.rs 81.81% <81.81%> (ø)

... and 3 files with indirect coverage changes

@andrewgazelka andrewgazelka marked this pull request as ready for review December 4, 2024 09:27
@andrewgazelka andrewgazelka force-pushed the andrew/connect-filter branch 4 times, most recently from 36c9aa0 to abfed9f Compare December 9, 2024 22:10
@andrewgazelka andrewgazelka changed the title [FEAT] connect: add df.filter feat(connect): add df.filter Dec 10, 2024
@github-actions github-actions bot added the feat label Dec 10, 2024
Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with this codebase, but looks good to me. LGTM!

@andrewgazelka andrewgazelka force-pushed the andrew/connect-filter branch 2 times, most recently from 0188ea3 to ae03371 Compare December 11, 2024 21:04
@andrewgazelka andrewgazelka merged commit 8d93a27 into main Dec 11, 2024
43 of 44 checks passed
Copy link
Contributor Author

Merge activity

  • Dec 11, 4:54 PM EST: A user merged this pull request with Graphite.

@andrewgazelka andrewgazelka deleted the andrew/connect-filter branch December 11, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants