Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] connect: df.join #3354

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[FEAT] connect: df.join #3354

wants to merge 2 commits into from

Conversation

andrewgazelka
Copy link
Member

@andrewgazelka andrewgazelka commented Nov 20, 2024 •
edited
Loading

  • fix
E           pyspark.errors.exceptions.connect.SparkConnectGrpcException: <_MultiThreadedRendezvous of RPC that terminated with:
E               status = StatusCode.INTERNAL
E               details = "Error in Daft server: Not Yet Implemented: Joins without join conditions (cross join) are not supported yet
E           
E           Location:
E               src/daft-connect/src/op/execute/root.rs:37:39"
E               debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:55241 {created_time:"2024-11-21T09:18:54.065079-08:00", grpc_status:13, grpc_message:"Error in Daft server: Not Yet Implemented: Joins without join conditions (cross join) are not supported yet\n\nLocation:\n    src/daft-connect/src/op/execute/root.rs:37:39"}"
E           >

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 09:12
@andrewgazelka Graphite App
Copy link
Member Author

andrewgazelka commented Nov 20, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka changed the base branch from andrew/connect-alias to andrew/connect-refactor-to-ref November 20, 2024 09:25
This was referenced Nov 20, 2024
Merged
Draft
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 863ac08 to c999ae9 Compare November 20, 2024 18:24
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from c999ae9 to 394c381 Compare November 20, 2024 18:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 394c381 to 3fb2d4f Compare November 20, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 3fb2d4f to 4f49d30 Compare November 20, 2024 18:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 4f49d30 to e95abbd Compare November 20, 2024 19:32
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from e95abbd to 0e54699 Compare November 20, 2024 22:12
@andrewgazelka andrewgazelka force-pushed the andrew/connect-refactor-to-ref branch from 0e54699 to cdcd749 Compare November 20, 2024 23:28
@andrewgazelka andrewgazelka mentioned this pull request Nov 21, 2024
Draft
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from a271b0e to 0aa969e Compare December 10, 2024 06:25
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from 0aa969e to 4571ac7 Compare December 10, 2024 23:54
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from 4571ac7 to c69c326 Compare December 11, 2024 21:05
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from c69c326 to b8102f4 Compare December 11, 2024 21:07
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from b8102f4 to 2655dd6 Compare December 11, 2024 21:11
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from 2655dd6 to fa1b9d8 Compare December 11, 2024 22:02
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from fa1b9d8 to aa0e040 Compare December 16, 2024 21:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from 1d3cf31 to bfb5553 Compare December 17, 2024 20:48
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from bfb5553 to 3b6e9a6 Compare December 18, 2024 19:17
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from 3b6e9a6 to edc5d8b Compare December 19, 2024 00:41
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from edc5d8b to 2f003bd Compare December 19, 2024 02:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from 2f003bd to 8268bf6 Compare December 19, 2024 10:15
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with-columns-renamed branch from 8268bf6 to 0aa67fb Compare December 19, 2024 17:05
Base automatically changed from andrew/connect-with-columns-renamed to main December 19, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@universalmind303 universalmind303 universalmind303 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewgazelka @universalmind303