-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] connect: createDataFrame #3363
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
22d7e93
to
83f2117
Compare
864f8ba
to
2c4ef28
Compare
83f2117
to
df7ffd5
Compare
2c4ef28
to
421d94b
Compare
df7ffd5
to
5c5279f
Compare
421d94b
to
1b03d12
Compare
5c5279f
to
ba57801
Compare
1b03d12
to
95bd95e
Compare
ba57801
to
81ff3b6
Compare
95bd95e
to
866aa05
Compare
81ff3b6
to
5ddc229
Compare
866aa05
to
59f0592
Compare
5ddc229
to
470d2de
Compare
59f0592
to
e319fb8
Compare
470d2de
to
89e89e8
Compare
e319fb8
to
b0aeaec
Compare
89e89e8
to
36a8d0c
Compare
b0aeaec
to
1380cd4
Compare
36a8d0c
to
6cfef48
Compare
596e61f
to
de51b3c
Compare
de51b3c
to
aefae24
Compare
a0165a6
to
caf0626
Compare
aefae24
to
6f3d6aa
Compare
6f3d6aa
to
d35c3e7
Compare
0d0dbe5
to
e82f9e5
Compare
CodSpeed Performance ReportMerging #3363 will degrade performances by 66.8%Comparing Summary
Benchmarks breakdown
|
c75d606
to
f636d74
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
==========================================
- Coverage 77.35% 77.29% -0.06%
==========================================
Files 696 699 +3
Lines 84849 85242 +393
==========================================
+ Hits 65631 65887 +256
- Misses 19218 19355 +137
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the feedback can be addressed later. But I definitely think we should remove the arrow_format
dependency before merging.
Also the with_columns
-> select
change is needed before merging
src/daft-connect/src/translation/logical_plan/local_relation.rs
Outdated
Show resolved
Hide resolved
src/daft-connect/src/translation/logical_plan/local_relation.rs
Outdated
Show resolved
Hide resolved
src/daft-connect/src/translation/logical_plan/local_relation.rs
Outdated
Show resolved
Hide resolved
1d96dba
to
0453921
Compare
0453921
to
69b2c29
Compare
No description provided.