Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: add more (internally P2) column operations (WIP) #3387

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewgazelka
Copy link
Member

No description provided.

Copy link
Member Author

andrewgazelka commented Nov 21, 2024

@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch from 39c1061 to 1631a8d Compare November 21, 2024 05:37
@andrewgazelka andrewgazelka changed the title [FEAT] connect: add more (internally P2) column operations [FEAT] connect: add more (internally P2) column operations (WIP) Nov 21, 2024
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 54468cc to 28173ab Compare November 21, 2024 16:57
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch from 1631a8d to 7b02dc1 Compare November 21, 2024 16:58
@andrewgazelka andrewgazelka mentioned this pull request Nov 21, 2024
1 task
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from 28173ab to cdca2e2 Compare November 21, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch from 7b02dc1 to 9db2f26 Compare November 21, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from cdca2e2 to fbc5c6e Compare November 27, 2024 07:42
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch from 9db2f26 to a2243d0 Compare November 27, 2024 07:42
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch from fbc5c6e to a2e0beb Compare December 4, 2024 02:09
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch from a2243d0 to fa3e27b Compare December 4, 2024 02:09
@andrewgazelka andrewgazelka force-pushed the andrew/connect-binary-operators branch 2 times, most recently from b9a7f70 to 3ee5757 Compare December 4, 2024 02:33
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch 2 times, most recently from 9fd596b to 3bebd08 Compare December 4, 2024 02:44
Base automatically changed from andrew/connect-binary-operators to main December 4, 2024 03:01
@github-actions github-actions bot added the enhancement New feature or request label Dec 4, 2024
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch from 3bebd08 to 5fadc26 Compare December 4, 2024 08:52
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #3387 will degrade performances by 32.02%

Comparing andrew/connect-columns-p2 (d08ffda) with main (ae74c10)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-columns-p2 Change
test_iter_rows_first_row[100 Small Files] 131.6 ms 193.6 ms -32.02%

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (ae74c10) to head (d08ffda).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3387      +/-   ##
==========================================
+ Coverage   77.84%   77.85%   +0.01%     
==========================================
  Files         718      718              
  Lines       88250    88254       +4     
==========================================
+ Hits        68696    68708      +12     
+ Misses      19554    19546       -8     
Files with missing lines Coverage Δ
...onnect/src/translation/expr/unresolved_function.rs 73.80% <100.00%> (+3.07%) ⬆️

... and 4 files with indirect coverage changes

@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch 9 times, most recently from 215fd6a to fdbc6ef Compare December 11, 2024 22:02
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch 6 times, most recently from 63ee498 to a49e465 Compare December 19, 2024 10:14
@andrewgazelka andrewgazelka force-pushed the andrew/connect-columns-p2 branch from a49e465 to d08ffda Compare December 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant