Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): Cutover deprecated APIs to use session, catalog, table abstractions [3/3] #3830

Merged
merged 22 commits into from
Feb 25, 2025

make get_table errors resolve to none like legacy behavior

8b8be7f
Select commit
Loading
Failed to load commit list.
Merged

feat(catalog): Cutover deprecated APIs to use session, catalog, table abstractions [3/3] #3830

make get_table errors resolve to none like legacy behavior
8b8be7f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 25, 2025 in 1s

78.06% (+0.14%) compared to 0098bee

View this Pull Request on Codecov

78.06% (+0.14%) compared to 0098bee

Details

Codecov Report

Attention: Patch coverage is 76.89970% with 76 lines in your changes missing coverage. Please review.

Project coverage is 78.06%. Comparing base (0098bee) to head (8b8be7f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
daft/session.py 67.16% 22 Missing ⚠️
src/daft-session/src/python.rs 21.05% 15 Missing ⚠️
src/daft-session/src/session.rs 86.86% 13 Missing ⚠️
daft/catalog/__init__.py 66.66% 11 Missing ⚠️
src/daft-catalog/src/error.rs 0.00% 8 Missing ⚠️
daft/catalog/__unity.py 25.00% 3 Missing ⚠️
src/daft-catalog/src/python.rs 88.88% 2 Missing ⚠️
daft/__init__.py 0.00% 1 Missing ⚠️
daft/catalog/__iceberg.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
+ Coverage   77.92%   78.06%   +0.14%     
==========================================
  Files         763      760       -3     
  Lines       95766    95865      +99     
==========================================
+ Hits        74626    74840     +214     
+ Misses      21140    21025     -115     
Files with missing lines Coverage Δ
src/daft-catalog/src/catalog.rs 0.00% <ø> (ø)
src/daft-catalog/src/identifier.rs 97.52% <100.00%> (+17.16%) ⬆️
src/daft-catalog/src/table.rs 74.19% <100.00%> (+2.76%) ⬆️
src/daft-sql/src/planner.rs 80.42% <100.00%> (+0.07%) ⬆️
src/daft-sql/src/python.rs 55.40% <ø> (ø)
src/lib.rs 96.15% <ø> (-0.15%) ⬇️
daft/__init__.py 23.07% <0.00%> (ø)
daft/catalog/__iceberg.py 76.08% <75.00%> (+17.39%) ⬆️
src/daft-catalog/src/python.rs 77.77% <88.88%> (+11.11%) ⬆️
daft/catalog/__unity.py 48.27% <25.00%> (ø)
... and 5 more

... and 9 files with indirect coverage changes