feat(catalog): Cutover deprecated APIs to use session, catalog, table abstractions [3/3] #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchowell
force-pushed
the
rchowell/catalog-3-of-3
branch
from
e4725d7 to
c47b29e
Compare
rchowell
force-pushed
the
rchowell/catalog-2-of-3
branch
from
f1a2a5a to
87810f1
Compare
rchowell
force-pushed
the
rchowell/catalog-2-of-3
branch
from
7165ed8 to
470d238
Compare
|
Looks like there's a lot of merge conflicts. Could you merge from main first? |
rchowell
force-pushed
the
rchowell/catalog-3-of-3
branch
from
91957d9 to
1a60f1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3830 +/- ##
==========================================
+ Coverage 77.92% 78.06% +0.14%
==========================================
Files 763 760 -3
Lines 95766 95865 +99
==========================================
+ Hits 74626 74840 +214
+ Misses 21140 21025 -115
|
universalmind303
approved these changes
Feb 25, 2025
kevinzwang
approved these changes
Feb 25, 2025
| } | ||
| } | ||
| pub curr_catalog: Option<String>, | ||
| pub curr_namespace: Option<Vec<String>>, |
There was a problem hiding this comment.
I see we're moving away from the term "namespace" and into "qualifier" in some places but not in others. How are you thinking about the difference between these two terms?
There was a problem hiding this comment.
- Here's the PR for qualified identifiers in SQL feat(sql): adds session sql for leveraging attached catalogs #3860
- Qualifies are the first parts of an identifier
- Namespaces are a path within a catalog.
The qualifier can contain a catalog, so it's not exactly a namespace. Namespace is like a dir in a volume if the volume is catalog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps existing functionality to be backed by the new session, catalog, and table APIs.
Changes
daft.register_python_catalog -> daft.attach_catalogdaft.unregister_catalog -> daft.detach_catalogdaft.read_table -> daft.read_table(via session)daft.register_table -> daft.attach_tableContext