Source management sorting #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saelmala
requested review from
bwallberg,
birme,
LucasMaupin,
ABLindberg and
malmen237
bwallberg
suggested changes
Aug 28, 2024
|
Added last connected date to the source card/ edit view: 
|
birme
pushed a commit
that referenced
this pull request
Aug 29, 2024
fix: generate correct gui-version on build
bwallberg
reviewed
Aug 30, 2024
src/api/manager/job/syncInventory.ts
Outdated
| return { | ||
| ...inventorySource, | ||
| status: apiSource.status | ||
| status: apiSource.status, | ||
| lastConnected: new Date() |
There was a problem hiding this comment.
I just learned ( yesterday ) that the API now actually stores some data about previously connected sources ( they used to just disappear... ) so we have check the status here and only update lastConnected if status !== "gone".
bwallberg
suggested changes
Aug 30, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
No sorting selected (in this case, the 'reverse sort order' button is disabled):
Sort on most recent is selected, reverse button NOT pressed:
Sort on most recent is selected, with the reverse button pressed: