-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul Client State Handling #3050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a75335
to
9c9a89f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3050 +/- ##
=============================================
- Coverage 58.88% 58.72% -0.16%
+ Complexity 4461 4459 -2
=============================================
Files 558 560 +2
Lines 20201 20458 +257
Branches 1035 1036 +1
=============================================
+ Hits 11895 12014 +119
- Misses 7757 7900 +143
+ Partials 549 544 -5
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
2c79f68
to
d83e7c7
Compare
This was referenced Nov 27, 2023
Closed
e5d96d7
to
47dbfb0
Compare
de871a9
to
918098f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the client maintains most state in the various UI controllers. This results in the view elements needing to be cached so as to not lose state. This is suboptimal because it has lead to memory leaks where some ui elements cannot be garbage collected even when they are removed from the scene.
Additionally there is no cleanup of elements and their listeners when they are removed from the UI which also contributes to memory leaks.
This PR aims to overhaul the state maintenance of the client such that views are just displays and can be created and discarded at will.
Tasks
Closes #2994
Closes #3016
Closes #3018