Update UEF SACU Enhancement Script

[MrRowey]

Following on the changes of #6498

Checklist

• Changes are annotated, including comments where useful
• Changes are documented in the changelog for the next game version

[Garanas]

This is an unintentional change - it would always be true. See also the RadarJammerEnh field that is set to true/false depending on whether the enhancement exists.

[MrRowey]

After looking at this can't this just be a part of the 2 Functions for the enhancements now?

[MrRowey]

So something like

    ---@param self UEL0301
    ---@param bp UnitBlueprintEnhancement
    ProcessEnhancementRadarJammer = function(self, bp)
        self:SetIntelRadius('Jammer', bp.NewJammerRadius or 26)
        self:EnableUnitIntel('Enhancement', 'Jammer')
        self:AddToggleCap('RULEUTC_JammingToggle')
        self:SetEnergyMaintenanceConsumptionOverride(bp.MaintenanceConsumptionPerSecondEnergy or 0)
        self:SetMaintenanceConsumptionActive()

        if self.IntelEffects then
            self.IntelEffectsBag = {}
            self:CreateTerrainTypeEffects(self.IntelEffects, 'FXIdle',  self.Layer, nil, self.IntelEffectsBag)
        end

    end,
    ```

[MrRowey]

but then do you even need the self.RadarJammerEnh = true if the part its setting ti for can now be apart of the same function as it wasn't before ?

[lL1l1]

You can't inline OnIntelEnabled because that function is called when the jamming toggle is pressed (or whenever else the jammer is enabled), while the enhancement function is called only once when the enhancement is built. Same for OnIntelDisabled.

If you did inline it, then the jammer's FX and and energy consumption would remain permanently on until the enhancement is removed.