Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#573 Remove deprecated player_info fields #980

Conversation

Askaholic
Copy link
Collaborator

PR to v2-develop branch. I intend on making a pre-release based on this branch soon. It will only contain the removal of deprecated fields/messages.

@Askaholic Askaholic requested a review from Sheikah45 October 17, 2023 21:21
Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields are no longer even de-serialized in the client

@Askaholic Askaholic merged commit b0f4ca4 into FAForever:v2-develop Nov 26, 2023
6 of 7 checks passed
@Askaholic Askaholic deleted the v2-remove-deprecated-player-info-fields branch November 26, 2023 18:23
Askaholic added a commit that referenced this pull request Nov 26, 2023
Askaholic added a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants