Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#573 Remove deprecated player_info fields #980

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Issue/#573 Remove deprecated player_info fields #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions server/players.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,6 @@ def filter_none(t):
}
for rating_type in self.ratings
}),
# Deprecated
("global_rating", self.ratings[RatingType.GLOBAL]),
("ladder_rating", self.ratings[RatingType.LADDER_1V1]),
("number_of_games", self.game_count[RatingType.GLOBAL]),
)
)
)
Expand Down
12 changes: 0 additions & 12 deletions tests/integration_tests/test_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ async def test_server_valid_login(lobby_server):
"number_of_games": 2
}
},
"global_rating": [1650.0, 62.52],
"ladder_rating": [1650.0, 62.52],
"number_of_games": 2
}
assert msg == {
"command": "welcome",
Expand Down Expand Up @@ -115,9 +112,6 @@ async def test_server_valid_login_admin(lobby_server):
"number_of_games": 5
}
},
"global_rating": [2000.0, 125.0],
"ladder_rating": [2000.0, 125.0],
"number_of_games": 5,
}
assert msg == {
"command": "welcome",
Expand Down Expand Up @@ -157,9 +151,6 @@ async def test_server_valid_login_moderator(lobby_server):
"number_of_games": 0
}
},
"global_rating": [1500, 500],
"ladder_rating": [1500, 500],
"number_of_games": 0
}
assert msg == {
"command": "welcome",
Expand Down Expand Up @@ -251,9 +242,6 @@ async def test_server_valid_login_with_token(lobby_server, jwk_priv_key, jwk_kid
"number_of_games": 2
}
},
"global_rating": [1650.0, 62.52],
"ladder_rating": [1650.0, 62.52],
"number_of_games": 2
}
assert msg == {
"command": "welcome",
Expand Down
6 changes: 0 additions & 6 deletions tests/integration_tests/test_teammatchmaker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,9 +610,6 @@ async def test_ratings_initialized_based_on_global(lobby_server):
"number_of_games": 5
}
},
"global_rating": [2000.0, 125.0],
"ladder_rating": [2000.0, 125.0],
"number_of_games": 5,
}
]
}
Expand Down Expand Up @@ -651,9 +648,6 @@ async def test_ratings_initialized_based_on_global(lobby_server):
"number_of_games": 0
}
},
"global_rating": [2000.0, 125.0],
"ladder_rating": [2000.0, 125.0],
"number_of_games": 5,
}


Expand Down
3 changes: 0 additions & 3 deletions tests/unit_tests/test_players.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ def test_serialize():
"number_of_games": 0
}
},
"global_rating": (1234, 68),
"ladder_rating": (1500, 230),
"number_of_games": 542,
}


Expand Down